-
Notifications
You must be signed in to change notification settings - Fork 1.5k
{Storage-Preview} az storage account migration: Remove cmd group as it has been GA in main repo, Remove DATA_COSMOS_TABLE and DATA_STORAGE
#8934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @calvinhzy, |
❌Azure CLI Extensions Breaking Change Test
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
az storage account migration: Remove cmd group as it has been GA in main repo, Remove DATA_COSMOS_TABLE and DATA_STORAGE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR aligns the storage-preview extension with GA changes by removing preview-specific command groups and utilities, bumping the extension version, and updating test recordings.
- Bump extension version to 1.0.0b7.
- Remove short-lived SAS helper functions and the preview migration test, as migration has GA elsewhere.
- Update test imports and refresh recorded interaction fixtures with new timestamps and headers.
Comments suppressed due to low confidence (1)
src/storage-preview/HISTORY.rst:1
- Please add a new entry in HISTORY.rst for version 1.0.0b7, summarizing the version bump and removed preview utilities.
.. :changelog:
… it has been GA in main repo, Remove DATA_COSMOS_TABLE and DATA_STORAGE (Azure#8934) * remove storage account migration as it has been GA in main repo * remove DATA_COSMOS_TABLE and DATA_STORAGE references * style
|
[Release] Update index.json for extension [ storage-preview-1.0.0b7 ] : https://dev.azure.com/msazure/One/_build/results?buildId=130828251&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.