Skip to content

Conversation

@calvinhzy
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@calvinhzy calvinhzy self-assigned this Jul 3, 2025
@azure-client-tools-bot-prd
Copy link

Hi @calvinhzy,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jul 3, 2025

❌Azure CLI Extensions Breaking Change Test
❌storage-preview
rule cmd_name rule_message suggest_message
1012 - SubgroupRemove storage account migration sub group storage account migration removed please confirm sub group storage account migration removed

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 3, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

github-actions bot commented Jul 3, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link

github-actions bot commented Jul 3, 2025

@github-actions
Copy link

github-actions bot commented Jul 3, 2025

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@calvinhzy calvinhzy changed the title {Storage-Preview} Remove storage account migration as it has been GA in main repo, Remove DATA_COSMOS_TABLE and DATA_STORAGE {Storage-Preview} az storage account migration: Remove cmd group as it has been GA in main repo, Remove DATA_COSMOS_TABLE and DATA_STORAGE Jul 7, 2025
@calvinhzy calvinhzy marked this pull request as ready for review July 7, 2025 05:28
Copilot AI review requested due to automatic review settings July 7, 2025 05:28
@calvinhzy calvinhzy requested a review from evelyn-ys as a code owner July 7, 2025 05:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aligns the storage-preview extension with GA changes by removing preview-specific command groups and utilities, bumping the extension version, and updating test recordings.

  • Bump extension version to 1.0.0b7.
  • Remove short-lived SAS helper functions and the preview migration test, as migration has GA elsewhere.
  • Update test imports and refresh recorded interaction fixtures with new timestamps and headers.
Comments suppressed due to low confidence (1)

src/storage-preview/HISTORY.rst:1

  • Please add a new entry in HISTORY.rst for version 1.0.0b7, summarizing the version bump and removed preview utilities.
.. :changelog:

@calvinhzy calvinhzy merged commit d19f65c into Azure:main Jul 7, 2025
24 checks passed
deepakmauryams pushed a commit to deepakmauryams/azure-cli-extensions that referenced this pull request Jul 7, 2025
… it has been GA in main repo, Remove DATA_COSMOS_TABLE and DATA_STORAGE (Azure#8934)

* remove storage account migration as it has been GA in main repo

* remove DATA_COSMOS_TABLE and DATA_STORAGE references

* style
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ storage-preview-1.0.0b7 ] : https://dev.azure.com/msazure/One/_build/results?buildId=130828251&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants