Skip to content

Conversation

@cdxu-147
Copy link
Member

@cdxu-147 cdxu-147 commented Jul 3, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az network alb security-policy waf

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings July 3, 2025 17:42
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jul 3, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@github-actions
Copy link

github-actions bot commented Jul 3, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 3, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR registers a new command group for WAF security policies under the network alb security-policy waf namespace and updates versioning.

  • Bumps extension version to 2.0.1
  • Adds the network alb security-policy waf command group in custom.py
  • Updates HISTORY.rst with the 2.0.1 release entry

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/alb/setup.py Updated VERSION from '2.0.0' to '2.0.1'
src/alb/azext_alb/custom.py Introduced @register_command_group and class for WAF security policies
src/alb/HISTORY.rst Added 2.0.1 release notes entry
Comments suppressed due to low confidence (2)

src/alb/azext_alb/custom.py:37

  • [nitpick] The class name __CMDGroup is ambiguous; consider renaming it to something more descriptive like WafSecurityPolicyCommandGroup to improve readability.
class __CMDGroup(AAZCommandGroup):

src/alb/azext_alb/custom.py:36

  • Consider adding or updating tests to cover the new network alb security-policy waf command group to ensure its commands are correctly registered and invoked.
@register_command_group("network alb security-policy waf")

@github-actions
Copy link

github-actions bot commented Jul 3, 2025

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link

github-actions bot commented Jul 3, 2025

Hi @cdxu-147

⚠️ Release Requirements

Module: alb

  • ⚠️ Please update VERSION to be 2.0.1b1 in src/alb/setup.py

Notes

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jul 3, 2025
@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 8936 in repo Azure/azure-cli-extensions

@yonzhan yonzhan requested a review from necusjz July 3, 2025 22:22
@yonzhan yonzhan requested a review from jsntcy July 3, 2025 22:22
@necusjz
Copy link
Member

necusjz commented Jul 4, 2025

@cdxu-147 let's modify _help.py instead of custom.py.

@necusjz
Copy link
Member

necusjz commented Jul 8, 2025

/azp run

@necusjz necusjz added skip-cal-version and removed release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. labels Jul 8, 2025
@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@necusjz
Copy link
Member

necusjz commented Jul 9, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@cdxu-147 cdxu-147 force-pushed the chengdexu/register-waf-command-group branch from c2b7dff to 85d889b Compare July 10, 2025 01:31
@necusjz
Copy link
Member

necusjz commented Jul 10, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@necusjz necusjz merged commit a50a7fc into Azure:main Jul 10, 2025
24 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ alb-2.0.1 ] : https://dev.azure.com/msazure/One/_build/results?buildId=129880641&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants