Skip to content

Conversation

@serbrech
Copy link
Member

@serbrech serbrech commented Jul 4, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings July 4, 2025 04:22
@azure-client-tools-bot-prd
Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

@azure-client-tools-bot-prd
Copy link

Hi @serbrech,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 4, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

github-actions bot commented Jul 4, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the vendored SDK for the Fleet extension targeting the 2025-04-01-preview API version, including generated operation modules and a PEP 561 marker file.

  • Added py.typed marker to enable typing for the vendored SDK
  • Introduced generated operation modules (_update_runs_operations.py, _fleets_operations.py, etc.)
  • Included placeholder customization file (_patch.py) for future SDK tweaks

Reviewed Changes

Copilot reviewed 43 out of 44 changed files in this pull request and generated 1 comment.

File Description
src/fleet/azext_fleet/vendored_sdks/v2025_04_01_preview/py.typed Added PEP 561 marker file
src/fleet/azext_fleet/vendored_sdks/v2025_04_01_preview/operations/_update_runs_operations.py Generated operations for updateRuns
src/fleet/azext_fleet/vendored_sdks/v2025_04_01_preview/operations/_patch.py Placeholder for SDK customizations
Comments suppressed due to low confidence (1)

src/fleet/azext_fleet/vendored_sdks/v2025_04_01_preview/operations/_update_runs_operations.py:410

  • Consider adding unit or integration tests for list_by_fleet (and other new methods like begin_create_or_update, begin_skip, etc.) to verify correct URL building, parameter handling, and paging.
    def list_by_fleet(self, resource_group_name: str, fleet_name: str, **kwargs: Any) -> ItemPaged["_models.UpdateRun"]:

"""
from typing import List

__all__: List[str] = [] # Add all objects you want publicly available to users at this package level
Copy link

Copilot AI Jul 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Populate __all__ with 'patch_sdk' (or other intended exports) so that users can import the customization function directly.

Suggested change
__all__: List[str] = [] # Add all objects you want publicly available to users at this package level
__all__: List[str] = ['patch_sdk'] # Add all objects you want publicly available to users at this package level

Copilot uses AI. Check for mistakes.
@github-actions
Copy link

github-actions bot commented Jul 4, 2025

Hi @serbrech

Release Suggestions

Module: fleet

  • Please log updates into to src/fleet/HISTORY.rst
  • Update VERSION to 1.6.0 in src/fleet/setup.py

Notes

@yonzhan yonzhan requested a review from kairu-ms July 4, 2025 07:04
@yonzhan yonzhan requested a review from jsntcy July 4, 2025 07:05
@serbrech
Copy link
Member Author

serbrech commented Jul 7, 2025

@kairu-ms @yonzhan this PR won't need review. I pushed it to show how to fix the setup in #8938 for @frantran

@kairu-ms
Copy link
Contributor

OK. Let me close this RP

@kairu-ms kairu-ms closed this Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants