-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[WebPubSub] Upgrade websocket version #8944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR upgrades the extension’s version and updates the websockets dependency to ensure compatibility with newer Python versions.
- Bump extension version from 1.7.0 to 1.8.0
- Update
websocketsdependency to~=13.0.1 - Add release notes for version 1.8.0 in HISTORY.rst
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/webpubsub/setup.py | Updated VERSION to 1.8.0 and bumped websockets to ~=13.0.1 |
| src/webpubsub/HISTORY.rst | Added 1.8.0 release entry and noted dependency upgrade |
Comments suppressed due to low confidence (2)
src/webpubsub/HISTORY.rst:8
- Typo and clarity: replace "to sure the compatibility with python 12" with "to ensure compatibility with Python 3.12".
* Upgrade `websockets` to `13.0.1` to sure the compatibility with python 12
src/webpubsub/setup.py:17
- This TODO has been addressed by bumping the version; consider removing or updating this comment to avoid outdated reminders.
# TODO: Confirm this is the right version number you want and it matches your
|
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
[Release] Update index.json for extension [ webpubsub-1.7.1 ] : https://dev.azure.com/msazure/One/_build/results?buildId=129494923&view=results |
* Upgrade websocket version * minor update * update version according to comments
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
Only upgrade dependency
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.