Skip to content

Conversation

@caoyihua
Copy link
Contributor

@caoyihua caoyihua commented Jul 8, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings July 8, 2025 02:30
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jul 8, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 8, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

github-actions bot commented Jul 8, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps the vme extension to 1.0.0b5, adds a check to disable spinner animations when stdout is not a TTY, and updates print behavior and documentation accordingly.

  • Increment extension version to 1.0.0b5
  • Introduce supports_animation to skip animations on non-interactive outputs
  • Add flush=True to print calls and rename CLI flags in the README

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/vme/setup.py Version bumped from 1.0.0b4 to 1.0.0b5
src/vme/azext_vme/utils.py Added supports_animation helper and conditional spinner disable
src/vme/azext_vme/custom.py Updated print statements with flush=True
src/vme/README.rst Changed --name flags to --cluster-name in examples
src/vme/HISTORY.rst Added release notes for version 1.0.0b5
Comments suppressed due to low confidence (2)

src/vme/azext_vme/utils.py:20

  • Consider adding a docstring to supports_animation to clarify its purpose and return value.
def supports_animation():

src/vme/azext_vme/utils.py:60

  • The new supports_animation logic isn't covered by tests; consider adding unit tests that mock sys.stdout.isatty() to verify both TTY and non-TTY behaviors.
    if not supports_animation():

except ResourceNotFoundError:
# The extension does not exist, proceed with installation
print(f"Installing extension {extension_type}...")
print(f"Installing extension {extension_type}...", flush=True)
Copy link

Copilot AI Jul 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] There are multiple print(..., flush=True) calls; extracting a small helper function could reduce duplication and improve readability.

Suggested change
print(f"Installing extension {extension_type}...", flush=True)
_print_flush(f"Installing extension {extension_type}...")

Copilot uses AI. Check for mistakes.
@github-actions
Copy link

github-actions bot commented Jul 8, 2025

@yonzhan yonzhan requested a review from kairu-ms July 8, 2025 03:16
@yonzhan yonzhan requested a review from jsntcy July 8, 2025 03:16
@kairu-ms kairu-ms merged commit f6a2188 into Azure:main Jul 14, 2025
26 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ vme-1.0.0b5 ] : https://dev.azure.com/msazure/One/_build/results?buildId=130248877&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants