-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[vme] Skip the animation for powershell ide #8947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR bumps the vme extension to 1.0.0b5, adds a check to disable spinner animations when stdout is not a TTY, and updates print behavior and documentation accordingly.
- Increment extension version to 1.0.0b5
- Introduce
supports_animationto skip animations on non-interactive outputs - Add
flush=Trueto print calls and rename CLI flags in the README
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/vme/setup.py | Version bumped from 1.0.0b4 to 1.0.0b5 |
| src/vme/azext_vme/utils.py | Added supports_animation helper and conditional spinner disable |
| src/vme/azext_vme/custom.py | Updated print statements with flush=True |
| src/vme/README.rst | Changed --name flags to --cluster-name in examples |
| src/vme/HISTORY.rst | Added release notes for version 1.0.0b5 |
Comments suppressed due to low confidence (2)
src/vme/azext_vme/utils.py:20
- Consider adding a docstring to
supports_animationto clarify its purpose and return value.
def supports_animation():
src/vme/azext_vme/utils.py:60
- The new
supports_animationlogic isn't covered by tests; consider adding unit tests that mocksys.stdout.isatty()to verify both TTY and non-TTY behaviors.
if not supports_animation():
| except ResourceNotFoundError: | ||
| # The extension does not exist, proceed with installation | ||
| print(f"Installing extension {extension_type}...") | ||
| print(f"Installing extension {extension_type}...", flush=True) |
Copilot
AI
Jul 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] There are multiple print(..., flush=True) calls; extracting a small helper function could reduce duplication and improve readability.
| print(f"Installing extension {extension_type}...", flush=True) | |
| _print_flush(f"Installing extension {extension_type}...") |
|
|
[Release] Update index.json for extension [ vme-1.0.0b5 ] : https://dev.azure.com/msazure/One/_build/results?buildId=130248877&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.