Skip to content

Conversation

@jrw
Copy link

@jrw jrw commented Jul 8, 2025

Using a raw docstring will allow backslashes like c:\samples and will fix the warning shown below.


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

Running this command:
az login SCOPE --service-principle -u USER --tenant TENANT -p SECRET
gives a warning:

/root/.azure/cliextensions/monitor-control-service/azext_amcs/aaz/latest/monitor/data_collection/rule/_create.py:18: SyntaxWarning: invalid escape sequence '\s' """Create a data collection rule.

This PR should fix the warning.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Raw docstring allows backslashes like c:\samples
@jrw jrw requested review from jsntcy and kairu-ms as code owners July 8, 2025 22:40
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jul 8, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @jrw,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 8, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

github-actions bot commented Jul 8, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@microsoft-github-policy-service microsoft-github-policy-service bot added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Jul 8, 2025
@microsoft-github-policy-service
Copy link
Contributor

Thank you for your contribution @jrw! We will review the pull request and get back to you soon.

@github-actions
Copy link

github-actions bot commented Jul 8, 2025

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link

github-actions bot commented Jul 8, 2025

Hi @jrw

Release Suggestions

Module: monitor-control-service

  • Please log updates into to src/monitor-control-service/HISTORY.rst
  • Update VERSION to 1.2.1 in src/monitor-control-service/setup.py

Notes

Copy link
Contributor

@kairu-ms kairu-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We fixed the string in our new version of aaz-dev-tools.

@kairu-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Account Auto-Assign Auto assign by bot customer-reported Issues that are reported by GitHub users external to the Azure organization.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants