Skip to content

Conversation

@shanefujs
Copy link
Member

@shanefujs shanefujs commented Jul 10, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

Azure/aaz#820

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings July 10, 2025 23:26
@azure-client-tools-bot-prd
Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 10, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the initial scaffolding for the StorageDiscovery Azure CLI extension, including packaging setup, autogenerated AAZ command definitions, and placeholder tests/documentation.

  • Adds setup.py and minimal setup.cfg for packaging the extension.
  • Generates AAZ command modules for workspace CRUD operations.
  • Includes stubbed test file, parameter loader, and README/HISTORY placeholders.

Reviewed Changes

Copilot reviewed 24 out of 24 changed files in this pull request and generated 1 comment.

File Description
src/storage-discovery/setup.py Defines package metadata and entry points
src/storage-discovery/azext_storage_discovery/_params.py Stubbed load_arguments function with no logic
src/storage-discovery/azext_storage_discovery/tests/latest/test_storage_discovery.py Empty test class with a TODO
src/storage-discovery/README.md Placeholder usage section
Comments suppressed due to low confidence (2)

src/storage-discovery/azext_storage_discovery/tests/latest/test_storage_discovery.py:13

  • Add concrete test cases in this class to validate key scenarios for your commands instead of leaving it empty with a pass.
    pass

src/storage-discovery/README.md:5

  • [nitpick] Expand the README with actual usage examples and descriptions of the available commands to help users get started.
Please add commands usage here.

@github-actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link

@yonzhan yonzhan requested a review from evelyn-ys July 11, 2025 00:46
@yonzhan yonzhan requested a review from calvinhzy July 11, 2025 00:47
@shanefujs shanefujs force-pushed the storagediscovery/0601preview branch from 649e651 to f0b4546 Compare July 15, 2025 23:31
@shanefujs
Copy link
Member Author

Initial push- generated cli extensions with the latest merged swagger.
Working on adding test cases for each operation, and will follow up with new commits.

@shanefujs shanefujs changed the title [WIP DONOTREVIEW] feat: [storage-discovery] initial commit (#1) [TypeSpec] .NET SDK generate request for Storage Discovery Jul 16, 2025
@shanefujs shanefujs changed the title [TypeSpec] .NET SDK generate request for Storage Discovery [storage-discovery] 06-01-preivew cli extension Jul 16, 2025
@shanefujs shanefujs force-pushed the storagediscovery/0601preview branch from 4a5f359 to 8c2e231 Compare July 24, 2025 22:08
@shanefujs
Copy link
Member Author

@evelyn-ys @calvinhzy Hi! this pr is ready for review. Please take a look.
Thank you!

@calvinhzy calvinhzy changed the title [storage-discovery] 06-01-preivew cli extension [Storage-Discovery] 2025-06-01-preivew initial preview Jul 25, 2025
@calvinhzy
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@shanefujs
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 8954 in repo Azure/azure-cli-extensions

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 31, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@shanefujs
Copy link
Member Author

updated README and example to be more accurate. Please advise if we need to run /azp run again

@shanefujs
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 8954 in repo Azure/azure-cli-extensions

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 31, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

calvinhzy
calvinhzy previously approved these changes Aug 1, 2025
@shanefujs
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 8954 in repo Azure/azure-cli-extensions

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 5, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

calvinhzy
calvinhzy previously approved these changes Aug 5, 2025
@calvinhzy
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@calvinhzy calvinhzy merged commit f94d74d into Azure:main Aug 5, 2025
24 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Aug 5, 2025

[Release] Update index.json for extension [ storage-discovery-1.0.0b1 ] : https://dev.azure.com/msazure/One/_build/results?buildId=132693575&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants