-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[Storage-Discovery] 2025-06-01-preivew initial preview #8954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds the initial scaffolding for the StorageDiscovery Azure CLI extension, including packaging setup, autogenerated AAZ command definitions, and placeholder tests/documentation.
- Adds
setup.pyand minimalsetup.cfgfor packaging the extension. - Generates AAZ command modules for workspace CRUD operations.
- Includes stubbed test file, parameter loader, and README/HISTORY placeholders.
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/storage-discovery/setup.py | Defines package metadata and entry points |
| src/storage-discovery/azext_storage_discovery/_params.py | Stubbed load_arguments function with no logic |
| src/storage-discovery/azext_storage_discovery/tests/latest/test_storage_discovery.py | Empty test class with a TODO |
| src/storage-discovery/README.md | Placeholder usage section |
Comments suppressed due to low confidence (2)
src/storage-discovery/azext_storage_discovery/tests/latest/test_storage_discovery.py:13
- Add concrete test cases in this class to validate key scenarios for your commands instead of leaving it empty with a pass.
pass
src/storage-discovery/README.md:5
- [nitpick] Expand the README with actual usage examples and descriptions of the available commands to help users get started.
Please add commands usage here.
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
649e651 to
f0b4546
Compare
|
Initial push- generated cli extensions with the latest merged swagger. |
4a5f359 to
8c2e231
Compare
|
@evelyn-ys @calvinhzy Hi! this pr is ready for review. Please take a look. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 8954 in repo Azure/azure-cli-extensions |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
updated README and example to be more accurate. Please advise if we need to run |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 8954 in repo Azure/azure-cli-extensions |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
...age_discovery/tests/latest/recordings/test_storage_discovery_workspace_basic_operations.yaml
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Commenter does not have sufficient privileges for PR 8954 in repo Azure/azure-cli-extensions |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
[Release] Update index.json for extension [ storage-discovery-1.0.0b1 ] : https://dev.azure.com/msazure/One/_build/results?buildId=132693575&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
Azure/aaz#820
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.