-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[HDInsight on AKS] Remove hdinsightonaks extension as it has been deprecated #8956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HDInsight on AKS] Remove hdinsightonaks extension as it has been deprecated #8956
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @2258093686, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
FumingZhang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, seems not touching aks-preview though
|
yes, aks-preview isn't touched. hdinsightonaks only appears in the recordings as part of extension index metadata. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the deprecated hdinsightonaks extension from the CLI by deleting its entries in the service registry and extension index, and removing the entire extension source.
- Deleted the
az hdinsight-on-akscommand registration inservice_name.json - Removed the
hdinsightonakssection fromsrc/index.json - Deleted the full
src/hdinsightonaksextension directory (setup, metadata, tests, commands, AAZ code)
Reviewed Changes
Copilot reviewed 75 out of 81 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| service_name.json | Removed the az hdinsight-on-aks service entry |
| src/index.json | Manually removed hdinsightonaks extension from index |
| src/hdinsightonaks | Deleted entire extension source folder |
Comments suppressed due to low confidence (1)
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Merge rights are restricted, but I can queue CI runs :) |
|
Hi,@kairu-ms ,could you help merge this PR ? Thanks! |
|
Hi, @kairu-ms ,Could you please help merge this PR? Thanks |
As the 'hdinsightonaks' service has been deprecated, the hdinsightonaks extension should be removed.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.