Skip to content

Conversation

@2258093686
Copy link
Member

@2258093686 2258093686 commented Jul 11, 2025

As the 'hdinsightonaks' service has been deprecated, the hdinsightonaks extension should be removed.


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings July 11, 2025 06:29
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jul 11, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @2258093686,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 11, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link

This comment was marked as outdated.

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, seems not touching aks-preview though

@2258093686
Copy link
Member Author

yes, aks-preview isn't touched. hdinsightonaks only appears in the recordings as part of extension index metadata.

@2258093686 2258093686 requested a review from Copilot July 14, 2025 01:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the deprecated hdinsightonaks extension from the CLI by deleting its entries in the service registry and extension index, and removing the entire extension source.

  • Deleted the az hdinsight-on-aks command registration in service_name.json
  • Removed the hdinsightonaks section from src/index.json
  • Deleted the full src/hdinsightonaks extension directory (setup, metadata, tests, commands, AAZ code)

Reviewed Changes

Copilot reviewed 75 out of 81 changed files in this pull request and generated no comments.

File Description
service_name.json Removed the az hdinsight-on-aks service entry
src/index.json Manually removed hdinsightonaks extension from index
src/hdinsightonaks Deleted entire extension source folder
Comments suppressed due to low confidence (1)

@2258093686 2258093686 requested a review from FumingZhang July 14, 2025 03:22
@FumingZhang
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@FumingZhang
Copy link
Member

Merge rights are restricted, but I can queue CI runs :)

@2258093686
Copy link
Member Author

Hi,@kairu-ms ,could you help merge this PR ? Thanks!

@2258093686
Copy link
Member Author

Hi, @kairu-ms ,Could you please help merge this PR? Thanks

@kairu-ms kairu-ms merged commit fa8e5e9 into Azure:main Jul 22, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants