Skip to content

Conversation

@reneeli123
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks update --migrate-vmas-to-vms

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings July 14, 2025 04:37
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jul 14, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @reneeli123,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 14, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR restores the previously disabled end-to-end test for migrating AKS clusters from Availability Set (VMAS) to Virtual Machines (VMs).

  • Uncomments and reactivates the test_aks_migrate_vmas_to_vms method, including its decorators.
  • Reinstates the cluster creation, migration update, and deletion commands within the test.
Comments suppressed due to low confidence (1)

@github-actions
Copy link

FumingZhang
FumingZhang previously approved these changes Jul 14, 2025
Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Live test passed!

  • test_aks_migrate_vmas_to_vms

@reneeli123 reneeli123 force-pushed the reneel/uncomment-vmas-migration-test branch from b2193d3 to 02307ff Compare July 14, 2025 06:52
@yonzhan
Copy link
Collaborator

yonzhan commented Jul 14, 2025

Please fix CI issues

@zhoxing-ms zhoxing-ms merged commit ef0c533 into Azure:main Jul 15, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants