Skip to content

Conversation

@cxznmhdcxz
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings July 14, 2025 06:09
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jul 14, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @cxznmhdcxz,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 14, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds an example section to the cluster node-profile create command help for the hdinsightonaks extension.

  • Introduces an examples: block under the command help.
  • Provides a single example showing how to create a node profile with specified SKU and worker count.
Comments suppressed due to low confidence (1)

src/hdinsightonaks/azext_hdinsightonaks/_help.py:21

  • The example is missing required parameters such as --resource-group and --cluster-name; including these will ensure the example is executable by users.
examples:

short-summary: Create a node profile with SKU and worker count.
examples:
- name: Create a node profile with SKU and worker count.
text: az hdinsight-on-aks cluster node-profile create --count 5 --node-type Worker --vm-size Standard_D16a_v4
Copy link

Copilot AI Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider using a YAML block scalar (e.g., text: >) for the example command to improve readability and prevent formatting issues with longer commands.

Suggested change
text: az hdinsight-on-aks cluster node-profile create --count 5 --node-type Worker --vm-size Standard_D16a_v4
text: >
az hdinsight-on-aks cluster node-profile create
--count 5
--node-type Worker
--vm-size Standard_D16a_v4

Copilot uses AI. Check for mistakes.
@github-actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link

Hi @cxznmhdcxz

Release Suggestions

Module: hdinsightonaks

  • Please log updates into to src/hdinsightonaks/HISTORY.rst
  • Update VERSION to 1.0.0b4 in src/hdinsightonaks/setup.py

Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants