Skip to content

Conversation

@mainred
Copy link
Member

@mainred mainred commented Jul 22, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jul 22, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @mainred,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 22, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@mainred mainred force-pushed the aks-agent branch 5 times, most recently from a6ff392 to f00da46 Compare July 29, 2025 02:52
@mainred mainred changed the title add interactive AI-powered deubgging tool az aks agent {AKS} Add interactive AI-powered deubgging tool az aks agent Jul 29, 2025
@evelyn-ys
Copy link
Member

evelyn-ys commented Aug 5, 2025

@mainred It's expected that members / contributors can trigger pipeline automatically. The current inefficient status is because of an ADO bug on permission detection. See bug ticket https://mseng.visualstudio.com/AzureDevOps/_workitems/edit/2272746

CLI team is also suffering from commenting /azp run for each commit but this bug just open there for months with no progress ☹️

@mainred
Copy link
Member Author

mainred commented Aug 6, 2025

@evelyn-ys @@yonzhan
I think aks-preview is also under component governance somewhere, could you please confirm? And as a dependency to aks-preview, the holmesgpt package will also be governed implicitly?

https://docs.opensource.microsoft.com/tools/cg/index.html

@wangzelin007
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@wangzelin007
Copy link
Member

wangzelin007 commented Aug 6, 2025

Hi @mainred
Component Detection does not work under pull requests.
If you want to ensure that the holmesgpt package will also be governed implicitly, please merge this PR.
Also, please do not modify the version—We can create a separate PR for the release once everything is confirmed to be compliant.

image

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Aug 8, 2025
@mainred mainred changed the title [DONT MERGE]{AKS} Add interactive AI-powered deubugging tool az aks agent {AKS} Add interactive AI-powered deubugging tool az aks agent Aug 14, 2025
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Aug 14, 2025
@FumingZhang
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@mainred
Copy link
Member Author

mainred commented Aug 14, 2025

@FumingZhang please help merge this PR if there's no other changes required.

@mainred mainred changed the title {AKS} Add interactive AI-powered deubugging tool az aks agent {AKS} Add framework for interactive AI agent tool Aug 15, 2025
@FumingZhang
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

:param refresh_toolsets: Refresh the toolsets status.
:type refresh_toolsets: bool
"""
with CLITelemetryClient():
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AKS wants to leverage its own monitoring to collect metrics more than cli startup as well as tool calling and token usages etc. in the future.

action="store_true",
)

# pylint: disable=line-too-long
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I ask why these lines of code need to be commented out? If the parameters should be removed, please delete them directly.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We comment them out because these code will be introduced by one week or so later.
Currently we are under private preview to not expose this feature the user, unless the private preview looks good.

Copy link
Member Author

@mainred mainred Aug 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the agent subcommand from commands.py requires us to remove the parameters and helps to meet the requirement of style check. We want to keep as many code as possible though.
Keeping them here so that we can bring them back soon. If you are against from commenting so many code, I am fine to remove them directly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Just commenting them out temporarily is fine.

@yanzhudd yanzhudd merged commit fb7fc37 into Azure:main Aug 15, 2025
24 checks passed
@mainred mainred deleted the aks-agent branch August 15, 2025 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants