-
Notifications
You must be signed in to change notification settings - Fork 1.5k
{AKS} Add framework for interactive AI agent tool #8990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @mainred, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
a6ff392 to
f00da46
Compare
az aks agentaz aks agent
|
@mainred It's expected that members / contributors can trigger pipeline automatically. The current inefficient status is because of an ADO bug on permission detection. See bug ticket https://mseng.visualstudio.com/AzureDevOps/_workitems/edit/2272746 CLI team is also suffering from commenting |
|
@evelyn-ys @@yonzhan |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Hi @mainred |
az aks agentaz aks agent
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@FumingZhang please help merge this PR if there's no other changes required. |
az aks agent|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
| :param refresh_toolsets: Refresh the toolsets status. | ||
| :type refresh_toolsets: bool | ||
| """ | ||
| with CLITelemetryClient(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AKS wants to leverage its own monitoring to collect metrics more than cli startup as well as tool calling and token usages etc. in the future.
| action="store_true", | ||
| ) | ||
|
|
||
| # pylint: disable=line-too-long |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May I ask why these lines of code need to be commented out? If the parameters should be removed, please delete them directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We comment them out because these code will be introduced by one week or so later.
Currently we are under private preview to not expose this feature the user, unless the private preview looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the agent subcommand from commands.py requires us to remove the parameters and helps to meet the requirement of style check. We want to keep as many code as possible though.
Keeping them here so that we can bring them back soon. If you are against from commenting so many code, I am fine to remove them directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. Just commenting them out temporarily is fine.

This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.