Skip to content

Conversation

@zackliu
Copy link
Member

@zackliu zackliu commented Jul 23, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

Upgrade vendored sdks to latest version to ensure the compatibility with Python 3.13

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings July 23, 2025 00:57
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jul 23, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @zackliu,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades vendored SDKs to the latest version to ensure compatibility with Python 3.13 and bumps the WebPubSub extension version from 1.7.1 to 1.7.2.

  • Version bump from 1.7.1 to 1.7.2 in setup.py
  • Complete replacement of vendored WebPubSub SDK files with latest versions
  • Removal of legacy REST API files and addition of new SDK structure

Reviewed Changes

Copilot reviewed 33 out of 34 changed files in this pull request and generated no comments.

File Description
src/webpubsub/setup.py Version bump to 1.7.2
src/webpubsub/azext_webpubsub/vendored_sdks/azure_messaging_webpubsubservice/ Complete SDK replacement with new structure and Python 3.13 compatibility

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 23, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link

@kairu-ms
Copy link
Contributor

kairu-ms commented Aug 1, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@kairu-ms kairu-ms merged commit fd28eaa into Azure:main Aug 1, 2025
24 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Aug 1, 2025

[Release] Update index.json for extension [ webpubsub-1.7.2 ] : https://dev.azure.com/msazure/One/_build/results?buildId=132355009&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants