Skip to content

Conversation

@cxznmhdcxz
Copy link
Member

@cxznmhdcxz cxznmhdcxz commented Jul 24, 2025

aaz Azure/aaz#818


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings July 24, 2025 07:26
@azure-client-tools-bot-prd
Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

@azure-client-tools-bot-prd
Copy link

Hi @cxznmhdcxz,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 24, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a command example to the managementpartner extension and updates the minimum CLI core version requirement. The primary purpose is to improve documentation by providing users with a concrete usage example for the az managementpartner create command.

Key changes:

  • Added a practical command example showing how to create a management partner association
  • Updated minimum CLI core version from 2.61.0 to 2.75.0

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
azext_metadata.json Updated minimum CLI core version requirement to 2.75.0
_create.py Added command example to the docstring for the Create class

class Create(AAZCommand):
"""Associates a Microsoft Partner Network(MPN) ID to the current authenticated user or service principal.
:example: Associates a Microsoft Partner Network(MPN) ID to the current authenticated user or service principal.
Copy link

Copilot AI Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The example description repeats the class docstring. Consider making it more specific, such as ':example: Create a management partner association with MPN ID 123456'

Suggested change
:example: Associates a Microsoft Partner Network(MPN) ID to the current authenticated user or service principal.
:example: Create a management partner association with MPN ID 123456.

Copilot uses AI. Check for mistakes.
@github-actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link

Hi @cxznmhdcxz

Release Suggestions

Module: managementpartner

  • Please log updates into to src/managementpartner/HISTORY.rst
  • Update VERSION to 1.0.1 in src/managementpartner/setup.py

Notes

@kairu-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 19, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants