[fleet] add support for inline json to --stages argument in CLI #9000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| fleet updaterun create | cmd fleet updaterun create update parameter stages: removed property type=file_type |
||
| fleet updatestrategy create | cmd fleet updatestrategy create update parameter stages: removed property type=file_type |
|
Hi @serbrech, |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for inline JSON strings to the --stages argument in Azure fleet CLI commands, allowing users to provide stage configuration either as a file path or as inline JSON content.
Key Changes
- Modified parameter handling to accept both file paths and inline JSON strings for the
--stagesargument - Updated the core parsing logic to detect whether input is a file path or JSON string
- Added comprehensive test coverage for the new inline JSON functionality
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/fleet/azext_fleet/_params.py |
Updated parameter definitions to remove file type restrictions and clarify help text for inline JSON support |
src/fleet/azext_fleet/custom.py |
Modified get_update_run_strategy function to handle both file paths and inline JSON strings |
src/fleet/azext_fleet/tests/latest/test_stages_json.py |
Added comprehensive test suite covering file path, inline JSON, and error scenarios |
Comments suppressed due to low confidence (1)
src/fleet/azext_fleet/tests/latest/test_stages_json.py:252
- [nitpick] Consider adding test cases for other error scenarios such as missing required fields (e.g., missing 'stages' key, missing 'name' in stage/group) to ensure robust error handling.
invalid_json = '{"stages": [{"name": "test", invalid_syntax}]}'
|
Hi @serbrech
|
Member
Author
|
@kairu-ms happy to merge this after your review |
Member
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 9000 in repo Azure/azure-cli-extensions |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
kairu-ms
previously approved these changes
Jul 30, 2025
Member
Author
|
github-actions
bot
added
the
release-version-block
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
kairu-ms
removed
the
release-version-block
Co-authored-by: serbrech <[email protected]>
Co-authored-by: serbrech <[email protected]>
Co-authored-by: serbrech <[email protected]>
… enhancement Co-authored-by: serbrech <[email protected]>
github-actions
bot
added
the
release-version-block
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
kairu-ms
removed
the
release-version-block
github-actions
bot
added
the
release-version-block
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
kairu-ms
added
skip-cal-version
and removed
release-version-block
kairu-ms
approved these changes
Jul 31, 2025
Collaborator
|
[Release] Update index.json for extension [ fleet-1.6.1 ] : https://dev.azure.com/msazure/One/_build/results?buildId=132232791&view=results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8979
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az fleet
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.