-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Fix Quantum e2e tests to obfuscate test recording data #9004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Obfuscate api keys, connection strings, subscription id, resource group name, resource name in recordings.
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @katymccl, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds comprehensive data obfuscation to the Quantum extension's end-to-end test recordings to prevent sensitive information from being checked into the repository. The changes enhance security by automatically redacting API keys, connection strings, subscription IDs, resource group names, and other sensitive quantum workspace data from test recording files.
Key Changes
- Added new PowerShell functions to obfuscate API keys and quantum workspace sensitive data
- Integrated the new obfuscation functions into the existing test recording cleanup process
- Extended the existing SAS token obfuscation with additional security measures
|
Hi @katymccl Release SuggestionsModule: quantum
Notes
|
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
|
/azp run |
|
Commenter does not have sufficient privileges for PR 9004 in repo Azure/azure-cli-extensions |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@jsntcy can you please review this? |
|
I don't have permissions to merge this; @kairu-ms can you please merge this pr? |
Obfuscate api keys, connection strings, subscription id, resource group name, resource name in recordings. This is in response to an MSRC flagged vulnerability
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.