Skip to content

Conversation

@FumingZhang
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

Syncing change in official azure-cli Azure/azure-cli#31854

  • [AKS] az aks create: Add new parameter --disable-run-command to disable run command feature for the cluster
  • [AKS] az aks update: Add new parameters --disable-run-command and --enable-run-command to toggle the run command feature on or off

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings July 29, 2025 08:06
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jul 29, 2025

⚠️Azure CLI Extensions Breaking Change Test
⚠️aks-preview
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd aks create cmd aks create added parameter disable_run_command
⚠️ 1006 - ParaAdd aks update cmd aks update added parameter disable_run_command
⚠️ 1006 - ParaAdd aks update cmd aks update added parameter enable_run_command

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 29, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for toggling the run command feature on or off in AKS clusters by introducing new command options to control the run command configuration. The changes sync with the official Azure CLI to bring the run command feature toggle functionality to the AKS preview extension.

  • Added --disable-run-command parameter to az aks create for disabling the run command feature during cluster creation
  • Added --enable-run-command and --disable-run-command parameters to az aks update for toggling the run command feature on existing clusters
  • Implementation follows the existing pattern of other feature toggles with proper validation and mutual exclusivity checks

Reviewed Changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
setup.py Version bump to 18.0.0b23 for the new release
_params.py Added new parameter definitions for disable/enable run command options
_help.py Added help text documentation for the new run command parameters
custom.py Added parameters to function signatures for the new run command options
managed_cluster_decorator.py Core implementation of run command functionality with context methods and decorator methods
test_managed_cluster_decorator.py Unit tests for run command context methods and decorator functionality
test_aks_commands.py Integration test to verify run command toggle behavior in live cluster scenarios
HISTORY.rst Documentation of the new feature addition in the changelog
Comments suppressed due to low confidence (1)

src/aks-preview/azext_aks_preview/managed_cluster_decorator.py:4949

  • This line appears to have incorrect indentation. It should align with the opening parenthesis or use 4-space indentation consistent with the rest of the codebase.
                )

@github-actions
Copy link

1 similar comment
@github-actions
Copy link

@FumingZhang
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@FumingZhang
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@FumingZhang
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@FumingZhang FumingZhang force-pushed the fuming/aks-runcommand-0729 branch from dc8cce5 to f19cb15 Compare July 31, 2025 04:38
@zhoxing-ms zhoxing-ms merged commit 6398ad4 into Azure:main Jul 31, 2025
24 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ aks-preview-18.0.0b23 ] : https://dev.azure.com/msazure/One/_build/results?buildId=132243782&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants