-
Notifications
You must be signed in to change notification settings - Fork 1.5k
{AKS} Add command options to toggle the run command feature on or off #9014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{AKS} Add command options to toggle the run command feature on or off #9014
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks create | cmd aks create added parameter disable_run_command |
||
| aks update | cmd aks update added parameter disable_run_command |
||
| aks update | cmd aks update added parameter enable_run_command |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for toggling the run command feature on or off in AKS clusters by introducing new command options to control the run command configuration. The changes sync with the official Azure CLI to bring the run command feature toggle functionality to the AKS preview extension.
- Added
--disable-run-commandparameter toaz aks createfor disabling the run command feature during cluster creation - Added
--enable-run-commandand--disable-run-commandparameters toaz aks updatefor toggling the run command feature on existing clusters - Implementation follows the existing pattern of other feature toggles with proper validation and mutual exclusivity checks
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| setup.py | Version bump to 18.0.0b23 for the new release |
| _params.py | Added new parameter definitions for disable/enable run command options |
| _help.py | Added help text documentation for the new run command parameters |
| custom.py | Added parameters to function signatures for the new run command options |
| managed_cluster_decorator.py | Core implementation of run command functionality with context methods and decorator methods |
| test_managed_cluster_decorator.py | Unit tests for run command context methods and decorator functionality |
| test_aks_commands.py | Integration test to verify run command toggle behavior in live cluster scenarios |
| HISTORY.rst | Documentation of the new feature addition in the changelog |
Comments suppressed due to low confidence (1)
src/aks-preview/azext_aks_preview/managed_cluster_decorator.py:4949
- This line appears to have incorrect indentation. It should align with the opening parenthesis or use 4-space indentation consistent with the rest of the codebase.
)
|
1 similar comment
|
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
dc8cce5 to
f19cb15
Compare
|
[Release] Update index.json for extension [ aks-preview-18.0.0b23 ] : https://dev.azure.com/msazure/One/_build/results?buildId=132243782&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
Syncing change in official azure-cli Azure/azure-cli#31854
az aks create: Add new parameter--disable-run-commandto disable run command feature for the clusteraz aks update: Add new parameters--disable-run-commandand--enable-run-commandto toggle the run command feature on or offGeneral Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.