-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Fix issues with Post Commit in AVNM #9018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @Shivani-Msft, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes issues with Post Commit functionality in Azure Virtual Network Manager (AVNM) by incrementing the version from 2.0.0 to 2.0.1 and adding a descriptive comment about the routing fix.
- Version bump from 2.0.0 to 2.0.1
- Added comment explaining the post commit routing fix
|
|
||
| # HISTORY.rst entry. | ||
| VERSION = '2.0.0' | ||
| # Fixed post commit issue in routing |
Copilot
AI
Jul 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment 'Fixed post commit issue in routing' is too vague and doesn't provide sufficient context about what the issue was or how it was fixed. Consider adding more specific details about the nature of the routing issue and the solution implemented.
| # Fixed post commit issue in routing | |
| # Resolved an issue where routing configurations were not being updated correctly | |
| # after a commit operation. The fix ensures that the routing table is refreshed | |
| # immediately following a commit to reflect the latest changes. |
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
|
how can I unblock you? |
|
Please fix CI issues |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.