Skip to content

Conversation

@Shivani-Msft
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings July 29, 2025 18:48
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jul 29, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @Shivani-Msft,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 29, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes issues with Post Commit functionality in Azure Virtual Network Manager (AVNM) by incrementing the version from 2.0.0 to 2.0.1 and adding a descriptive comment about the routing fix.

  • Version bump from 2.0.0 to 2.0.1
  • Added comment explaining the post commit routing fix


# HISTORY.rst entry.
VERSION = '2.0.0'
# Fixed post commit issue in routing
Copy link

Copilot AI Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment 'Fixed post commit issue in routing' is too vague and doesn't provide sufficient context about what the issue was or how it was fixed. Consider adding more specific details about the nature of the routing issue and the solution implemented.

Suggested change
# Fixed post commit issue in routing
# Resolved an issue where routing configurations were not being updated correctly
# after a commit operation. The fix ensures that the routing table is refreshed
# immediately following a commit to reflect the latest changes.

Copilot uses AI. Check for mistakes.
@github-actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link

github-actions bot commented Jul 29, 2025

@Shivani-Msft
Copy link
Contributor Author

how can I unblock you?

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 1, 2025

Please fix CI issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants