-
Notifications
You must be signed in to change notification settings - Fork 1.5k
initial changes for stack-hci vmconnect command #9021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| stack-hci vmconnect | sub group stack-hci vmconnect added |
|
Hi @hvedati, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces new VM Connect functionality for Azure Stack HCI clusters, adding the ability to enable and disable VM Connect for virtual machines through the Azure CLI extension.
- Adds two new command classes (
VmConnectEnableandVmConnectDisable) to manage VM Connect functionality - Registers new CLI commands under the
stack-hci vmconnectcommand group - Implements REST API calls to provision and deprovision VM Connect services
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/stack-hci/azext_stack_hci/custom.py | Implements VmConnectEnable and VmConnectDisable classes with REST API integration |
| src/stack-hci/azext_stack_hci/commands.py | Registers new vmconnect enable/disable commands in the command table |
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
Co-authored-by: Copilot <[email protected]>
|
Hi @hvedati Release SuggestionsModule: stack-hci
Notes
|
| else: | ||
| return { | ||
| "message": ( | ||
| f"VM Connect provision job initiated successfully for VM: {vm_name}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we also share where RDP file is located?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This command is only going to open the port so I don't think we need to share the path here? They aren't passing the path to this command.
han-sogawa-microsoft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Validated that jobs are invoked correctly
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.