-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[Containerapp] az containerapp job list: Fix only 20 items returned
#9022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a pagination issue where the az containerapp job list command only returned 20 items instead of all available container app jobs. The fix implements proper pagination handling to retrieve all items by following nextLink values in the API response.
- Added pagination support for listing container app jobs by subscription and resource Group
- Implemented test case to verify the fix by creating 30 test jobs and confirming all are returned
- Updated version from 1.2.0b2 to 1.2.0b3
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/containerapp/setup.py | Version bump to 1.2.0b3 |
| src/containerapp/azext_containerapp/tests/latest/test_containerappjob_crud.py | Added test case to verify pagination fix with 30 test jobs |
| src/containerapp/azext_containerapp/_clients.py | Added pagination-aware methods for listing jobs by subscription and resource group |
| src/containerapp/HISTORY.rst | Updated release notes with the pagination fix |
Comments suppressed due to low confidence (6)
src/containerapp/azext_containerapp/_clients.py:136
- The variable name 'app' is misleading since this method handles container app jobs, not apps. Consider renaming to 'job' for clarity.
for app in j["value"]:
src/containerapp/azext_containerapp/_clients.py:144
- The variable name 'app' is misleading since this method handles container app jobs, not apps. Consider renaming to 'job' for clarity.
for app in j["value"]:
src/containerapp/azext_containerapp/_clients.py:165
- The variable name 'app' is misleading since this method handles container app jobs, not apps. Consider renaming to 'job' for clarity.
for app in j["value"]:
src/containerapp/azext_containerapp/_clients.py:173
- The variable name 'app' is misleading since this method handles container app jobs, not apps. Consider renaming to 'job' for clarity.
for app in j["value"]:
src/containerapp/azext_containerapp/_clients.py:125
- The variable name 'app_list' is misleading since this method handles container app jobs, not apps. Consider renaming to 'job_list' for clarity.
app_list = []
src/containerapp/azext_containerapp/_clients.py:152
- The variable name 'app_list' is misleading since this method handles container app jobs, not apps. Consider renaming to 'job_list' for clarity.
app_list = []
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
|
[Release] Update index.json for extension [ containerapp ] : https://dev.azure.com/msazure/One/_build/results?buildId=132117977&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.