Revert "Remove ingress scale settings (#8928)" #9023
Conversation
This reverts commit 1dca2de.
|
Hi @Juliehzl, |
❌Azure CLI Extensions Breaking Change Test
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Pull Request Overview
This PR reverts a previous commit that removed ingress scale settings (--min-replicas and --max-replicas parameters) from the az containerapp env premium-ingress commands. The revert restores the ability to configure replica scaling for premium ingress configurations.
- Restored
--min-replicasand--max-replicasparameters to premium ingress commands - Updated function signatures to accept the scaling parameters
- Modified tests to include scale configuration checks
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/containerapp/azext_containerapp/_params.py |
Re-added parameter definitions for min-replicas and max-replicas |
src/containerapp/azext_containerapp/custom.py |
Restored scale configuration logic in add/update functions |
src/containerapp/azext_containerapp/tests/latest/test_containerapp_commands.py |
Updated tests to include scale parameter validation |
src/containerapp/azext_containerapp/_help.py |
Updated help examples to include scale parameters |
src/containerapp/HISTORY.rst |
Removed the changelog entry about parameter removal |
|
|
||
|
|
||
| def add_environment_premium_ingress(cmd, name, resource_group_name, workload_profile_name, termination_grace_period=None, request_idle_timeout=None, header_count_limit=None, no_wait=False): | ||
| def add_environment_premium_ingress(cmd, name, resource_group_name, workload_profile_name, min_replicas, max_replicas, termination_grace_period=None, request_idle_timeout=None, header_count_limit=None, no_wait=False): |
There was a problem hiding this comment.
The min_replicas and max_replicas parameters are required (no default values) but the help text in _params.py suggests defaults ("Default 2" and "Default 10"). This inconsistency could confuse users about whether these parameters are required or optional.
| if workload_profile_name is not None: | ||
| ingress_config["workloadProfileName"] = workload_profile_name | ||
| if min_replicas is not None: | ||
| ingress_config["scale"] = scale |
There was a problem hiding this comment.
The scale dictionary is assigned to ingress_config multiple times (lines 3893 and 3896). This creates duplicate code that could be consolidated by checking if either min_replicas or max_replicas is not None before creating the scale object once.
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
Hi @Juliehzl Release SuggestionsModule: containerapp
Notes
|
Juliehzl
dismissed stale reviews from zhoxing-ms, evelyn-ys, and howang-ms
via
f63ead1
6 participants
This reverts commit 1dca2de.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.