Managed network fabric extension updates for 9.x CLI using 2025-07-15-stable API. #9027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…parameters 'network-device-name' to 'resource-name' for consistency.
❌Azure CLI Extensions Breaking Change Test
|
|
Hi @idanielsteven, |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the managed network fabric extension for the 7.x CLI to use the 2025-07-15-stable API version, replacing the previous 2024-06-15-preview API. The update introduces new certificate and password rotation commands, enhanced schema definitions, and identity management features for network devices.
Key Changes:
- Updates API version from 2024-06-15-preview to 2025-07-15 across all network fabric operations
- Adds new certificate and password rotation/resync commands for network fabrics
- Introduces device identity management functionality
- Expands schema definitions with new properties for QoS configuration, authorized transceivers, and secret rotation
Reviewed Changes
Copilot reviewed 90 out of 319 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| fabric operations | Updated API version and added new rotation/resync commands with enhanced response schemas |
| external network | Added new BFD administrative state commands and updated schemas with network fabric ID |
| device identity | Added complete identity management functionality with assign/remove/show/wait commands |
Comments suppressed due to low confidence (1)
src/managednetworkfabric/azext_managednetworkfabric/aaz/latest/networkfabric/fabric/_rotate_certificate.py:22
- The API version '2025-07-15' does not exist as of my knowledge cutoff in January 2025. This appears to be a future API version that may not be available yet.
"version": "2025-07-15",
| _args_schema.authorized_transceiver = AAZObjectArg( | ||
| options=["--authorized-transceiver"], | ||
| arg_group="Properties", | ||
| help="Authorized transciever configuration for NetworkFabric.", |
There was a problem hiding this comment.
The word 'transciever' is misspelled. It should be 'transceiver'.
Suggested change
| help="Authorized transciever configuration for NetworkFabric.", | |
| help="Authorized transceiver configuration for NetworkFabric.", |
microsoft-github-policy-service
bot
requested review from
jsntcy,
kairu-ms,
necusjz and
yonzhan
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
github-actions
bot
added
the
release-version-block
idanielsteven
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Managed network fabric extension updates for 7.x CLI using 2025-07-15-stable API.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.