Skip to content

Conversation

@Jing-song
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Aug 1, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 1, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

github-actions bot commented Aug 1, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@microsoft-github-policy-service microsoft-github-policy-service bot added the Auto-Assign Auto assign by bot label Aug 1, 2025
@github-actions
Copy link

github-actions bot commented Aug 1, 2025

@yonzhan yonzhan requested a review from kairu-ms August 1, 2025 05:17
@yonzhan yonzhan requested a review from jsntcy August 1, 2025 05:17
@Jing-song Jing-song marked this pull request as ready for review August 1, 2025 05:38
Copilot AI review requested due to automatic review settings August 1, 2025 05:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a resource SDK import error in the quantum extension by updating the import path for DeploymentMode from the deprecated resources module to the deployments module. The version is bumped to 1.0.0b7 and the minimum CLI core version requirement is updated to 2.76.0.

Key changes:

  • Corrected the import path for DeploymentMode to use the proper module location
  • Updated version to 1.0.0b7 with corresponding history entry
  • Increased minimum CLI core version requirement to 2.76.0

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
setup.py Version bump to 1.0.0b7
workspace.py Fixed import path for DeploymentMode from resources to deployments module
azext_metadata.json Updated minimum CLI core version to 2.76.0
HISTORY.rst Added changelog entry for version 1.0.0b7


from azure.mgmt.resource import ResourceManagementClient
from azure.mgmt.resource.resources.models import DeploymentMode
from azure.mgmt.resource.deployments.models import DeploymentMode
Copy link

Copilot AI Aug 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import path azure.mgmt.resource.deployments.models appears to be incorrect. The correct import path for DeploymentMode should be azure.mgmt.resource.resources.models or possibly azure.mgmt.resource.models depending on the azure-mgmt-resource version. Please verify the correct module path for your target SDK version.

Copilot uses AI. Check for mistakes.
@kairu-ms kairu-ms merged commit 92bbda8 into Azure:main Aug 5, 2025
32 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Aug 5, 2025

[Release] Update index.json for extension [ quantum-1.0.0b7 ] : https://dev.azure.com/msazure/One/_build/results?buildId=132719215&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants