-
Notifications
You must be signed in to change notification settings - Fork 1.5k
{Quantum} Fix resource SDK import error #9034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a resource SDK import error in the quantum extension by updating the import path for DeploymentMode from the deprecated resources module to the deployments module. The version is bumped to 1.0.0b7 and the minimum CLI core version requirement is updated to 2.76.0.
Key changes:
- Corrected the import path for
DeploymentModeto use the proper module location - Updated version to 1.0.0b7 with corresponding history entry
- Increased minimum CLI core version requirement to 2.76.0
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| setup.py | Version bump to 1.0.0b7 |
| workspace.py | Fixed import path for DeploymentMode from resources to deployments module |
| azext_metadata.json | Updated minimum CLI core version to 2.76.0 |
| HISTORY.rst | Added changelog entry for version 1.0.0b7 |
|
|
||
| from azure.mgmt.resource import ResourceManagementClient | ||
| from azure.mgmt.resource.resources.models import DeploymentMode | ||
| from azure.mgmt.resource.deployments.models import DeploymentMode |
Copilot
AI
Aug 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The import path azure.mgmt.resource.deployments.models appears to be incorrect. The correct import path for DeploymentMode should be azure.mgmt.resource.resources.models or possibly azure.mgmt.resource.models depending on the azure-mgmt-resource version. Please verify the correct module path for your target SDK version.
|
[Release] Update index.json for extension [ quantum-1.0.0b7 ] : https://dev.azure.com/msazure/One/_build/results?buildId=132719215&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.