Skip to content

Conversation

@idanielsteven
Copy link
Contributor

Managed network fabric extension updates for 7.x CLI using 2025-07-15-stable API.


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings August 4, 2025 15:15
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Aug 4, 2025

❌Azure CLI Extensions Breaking Change Test
❌managednetworkfabric
rule cmd_name rule_message suggest_message
1008 - ParaPropAdd networkfabric device upgrade cmd networkfabric device upgrade update parameter version: added property required=True please remove property required=True for parameter version of cmd networkfabric device upgrade
1012 - SubgroupRemove networkfabric fabric identity sub group networkfabric fabric identity removed please confirm sub group networkfabric fabric identity removed
1007 - ParaRemove networkfabric l3domain create cmd networkfabric l3domain create removed parameter route_prefix_limit please add back parameter route_prefix_limit for cmd networkfabric l3domain create
1007 - ParaRemove networkfabric l3domain update cmd networkfabric l3domain update removed parameter route_prefix_limit please add back parameter route_prefix_limit for cmd networkfabric l3domain update
⚠️ 1006 - ParaAdd networkfabric acl create cmd networkfabric acl create added parameter control_plane_acl_configuration
⚠️ 1010 - ParaPropUpdate networkfabric acl create cmd networkfabric acl create update parameter acl_type: updated property choices from ['ControlPlaneTrafficPolicy', 'Management', 'Tenant'] to ['ControlPlaneAcl', 'ControlPlaneTrafficPolicy', 'Management', 'Tenant']
⚠️ 1006 - ParaAdd networkfabric acl update cmd networkfabric acl update added parameter control_plane_acl_configuration
⚠️ 1010 - ParaPropUpdate networkfabric acl update cmd networkfabric acl update update parameter acl_type: updated property choices from ['ControlPlaneTrafficPolicy', 'Management', 'Tenant'] to ['ControlPlaneAcl', 'ControlPlaneTrafficPolicy', 'Management', 'Tenant']
⚠️ 1011 - SubgroupAdd networkfabric bootstrapdevice sub group networkfabric bootstrapdevice added
⚠️ 1011 - SubgroupAdd networkfabric bootstrapinterface sub group networkfabric bootstrapinterface added
⚠️ 1006 - ParaAdd networkfabric controller create cmd networkfabric controller create added parameter mi_system_assigned
⚠️ 1006 - ParaAdd networkfabric controller create cmd networkfabric controller create added parameter mi_user_assigned
⚠️ 1006 - ParaAdd networkfabric controller update cmd networkfabric controller update added parameter mi_system_assigned
⚠️ 1006 - ParaAdd networkfabric controller update cmd networkfabric controller update added parameter mi_user_assigned
⚠️ 1001 - CmdAdd networkfabric device resync-certificate cmd networkfabric device resync-certificate added
⚠️ 1001 - CmdAdd networkfabric device resync-password cmd networkfabric device resync-password added
⚠️ 1006 - ParaAdd networkfabric device run-rw cmd networkfabric device run-rw added parameter command_url
⚠️ 1006 - ParaAdd networkfabric device update cmd networkfabric device update added parameter identity_selector
⚠️ 1006 - ParaAdd networkfabric device update cmd networkfabric device update added parameter mi_system_assigned
⚠️ 1006 - ParaAdd networkfabric device update cmd networkfabric device update added parameter mi_user_assigned
⚠️ 1006 - ParaAdd networkfabric device upgrade cmd networkfabric device upgrade added parameter rw_device_config_url
⚠️ 1010 - ParaPropUpdate networkfabric externalnetwork update-bfd-administrative-state cmd networkfabric externalnetwork update-bfd-administrative-state update parameter external_network_name: updated property options from ['--external-network-name'] to ['--external-network-name', '--resource-name']
⚠️ 1001 - CmdAdd networkfabric externalnetwork update-static-route-bfd-administrative-state cmd networkfabric externalnetwork update-static-route-bfd-administrative-state added
⚠️ 1010 - ParaPropUpdate networkfabric fabric arm-configuration-diff cmd networkfabric fabric arm-configuration-diff update parameter network_fabric_name: updated property options from ['--network-fabric-name'] to ['--network-fabric-name', '--resource-name']
⚠️ 1010 - ParaPropUpdate networkfabric fabric commit-batch-status cmd networkfabric fabric commit-batch-status update parameter network_fabric_name: updated property options from ['--network-fabric-name'] to ['--network-fabric-name', '--resource-name']
⚠️ 1006 - ParaAdd networkfabric fabric commit-configuration cmd networkfabric fabric commit-configuration added parameter commit_policy
⚠️ 1006 - ParaAdd networkfabric fabric commit-configuration cmd networkfabric fabric commit-configuration added parameter commit_stage
⚠️ 1006 - ParaAdd networkfabric fabric commit-configuration cmd networkfabric fabric commit-configuration added parameter devices
⚠️ 1006 - ParaAdd networkfabric fabric create cmd networkfabric fabric create added parameter authorized_transceiver
⚠️ 1006 - ParaAdd networkfabric fabric create cmd networkfabric fabric create added parameter feature_flags
⚠️ 1006 - ParaAdd networkfabric fabric create cmd networkfabric fabric create added parameter qos_configuration
⚠️ 1010 - ParaPropUpdate networkfabric fabric discard-commit-batch cmd networkfabric fabric discard-commit-batch update parameter network_fabric_name: updated property options from ['--network-fabric-name'] to ['--network-fabric-name', '--resource-name']
⚠️ 1010 - ParaPropUpdate networkfabric fabric lock-fabric cmd networkfabric fabric lock-fabric update parameter network_fabric_name: updated property options from ['--network-fabric-name'] to ['--network-fabric-name', '--resource-name']
⚠️ 1001 - CmdAdd networkfabric fabric resync-certificate cmd networkfabric fabric resync-certificate added
⚠️ 1001 - CmdAdd networkfabric fabric resync-password cmd networkfabric fabric resync-password added
⚠️ 1001 - CmdAdd networkfabric fabric rotate-certificate cmd networkfabric fabric rotate-certificate added
⚠️ 1001 - CmdAdd networkfabric fabric rotate-password cmd networkfabric fabric rotate-password added
⚠️ 1006 - ParaAdd networkfabric fabric update cmd networkfabric fabric update added parameter authorized_transceiver
⚠️ 1006 - ParaAdd networkfabric fabric update cmd networkfabric fabric update added parameter feature_flags
⚠️ 1006 - ParaAdd networkfabric fabric update cmd networkfabric fabric update added parameter qos_configuration
⚠️ 1010 - ParaPropUpdate networkfabric fabric view-device-configuration cmd networkfabric fabric view-device-configuration update parameter network_fabric_name: updated property options from ['--network-fabric-name'] to ['--network-fabric-name', '--resource-name']
⚠️ 1006 - ParaAdd networkfabric interface update cmd networkfabric interface update added parameter mi_system_assigned
⚠️ 1006 - ParaAdd networkfabric interface update cmd networkfabric interface update added parameter mi_user_assigned
⚠️ 1001 - CmdAdd networkfabric internalnetwork update-static-route-bfd-administrative-state cmd networkfabric internalnetwork update-static-route-bfd-administrative-state added
⚠️ 1006 - ParaAdd networkfabric l2domain create cmd networkfabric l2domain create added parameter mi_system_assigned
⚠️ 1006 - ParaAdd networkfabric l2domain create cmd networkfabric l2domain create added parameter mi_user_assigned
⚠️ 1006 - ParaAdd networkfabric l2domain update cmd networkfabric l2domain update added parameter mi_system_assigned
⚠️ 1006 - ParaAdd networkfabric l2domain update cmd networkfabric l2domain update added parameter mi_user_assigned
⚠️ 1006 - ParaAdd networkfabric l3domain create cmd networkfabric l3domain create added parameter export_policy_configuration
⚠️ 1006 - ParaAdd networkfabric l3domain create cmd networkfabric l3domain create added parameter mi_system_assigned
⚠️ 1006 - ParaAdd networkfabric l3domain create cmd networkfabric l3domain create added parameter mi_user_assigned
⚠️ 1006 - ParaAdd networkfabric l3domain create cmd networkfabric l3domain create added parameter v4route_prefix_limit
⚠️ 1006 - ParaAdd networkfabric l3domain create cmd networkfabric l3domain create added parameter v6route_prefix_limit
⚠️ 1006 - ParaAdd networkfabric l3domain update cmd networkfabric l3domain update added parameter export_policy_configuration
⚠️ 1006 - ParaAdd networkfabric l3domain update cmd networkfabric l3domain update added parameter mi_system_assigned
⚠️ 1006 - ParaAdd networkfabric l3domain update cmd networkfabric l3domain update added parameter mi_user_assigned
⚠️ 1006 - ParaAdd networkfabric l3domain update cmd networkfabric l3domain update added parameter v4route_prefix_limit
⚠️ 1006 - ParaAdd networkfabric l3domain update cmd networkfabric l3domain update added parameter v6route_prefix_limit
⚠️ 1006 - ParaAdd networkfabric neighborgroup create cmd networkfabric neighborgroup create added parameter mi_system_assigned
⚠️ 1006 - ParaAdd networkfabric neighborgroup create cmd networkfabric neighborgroup create added parameter mi_user_assigned
⚠️ 1001 - CmdAdd networkfabric neighborgroup resync cmd networkfabric neighborgroup resync added
⚠️ 1006 - ParaAdd networkfabric neighborgroup update cmd networkfabric neighborgroup update added parameter mi_system_assigned
⚠️ 1006 - ParaAdd networkfabric neighborgroup update cmd networkfabric neighborgroup update added parameter mi_user_assigned
⚠️ 1010 - ParaPropUpdate networkfabric nni create cmd networkfabric nni create update parameter fabric_name: updated property name from fabric_name to network_fabric_name
⚠️ 1010 - ParaPropUpdate networkfabric nni create cmd networkfabric nni create update parameter fabric_name: updated property options from ['--fabric', '--fabric-name'] to ['--fabric', '--fabric-name', '--network-fabric-name']
⚠️ 1010 - ParaPropUpdate networkfabric nni delete cmd networkfabric nni delete update parameter fabric_name: updated property name from fabric_name to network_fabric_name
⚠️ 1010 - ParaPropUpdate networkfabric nni delete cmd networkfabric nni delete update parameter fabric_name: updated property options from ['--fabric', '--fabric-name'] to ['--fabric', '--fabric-name', '--network-fabric-name']
⚠️ 1010 - ParaPropUpdate networkfabric nni list cmd networkfabric nni list update parameter fabric_name: updated property name from fabric_name to network_fabric_name
⚠️ 1010 - ParaPropUpdate networkfabric nni list cmd networkfabric nni list update parameter fabric_name: updated property options from ['--fabric', '--fabric-name'] to ['--fabric', '--fabric-name', '--network-fabric-name']
⚠️ 1010 - ParaPropUpdate networkfabric nni show cmd networkfabric nni show update parameter fabric_name: updated property name from fabric_name to network_fabric_name
⚠️ 1010 - ParaPropUpdate networkfabric nni show cmd networkfabric nni show update parameter fabric_name: updated property options from ['--fabric', '--fabric-name'] to ['--fabric', '--fabric-name', '--network-fabric-name']
⚠️ 1010 - ParaPropUpdate networkfabric nni update cmd networkfabric nni update update parameter fabric_name: updated property name from fabric_name to network_fabric_name
⚠️ 1010 - ParaPropUpdate networkfabric nni update cmd networkfabric nni update update parameter fabric_name: updated property options from ['--fabric', '--fabric-name'] to ['--fabric', '--fabric-name', '--network-fabric-name']
⚠️ 1010 - ParaPropUpdate networkfabric nni update-bfd-administrative-state cmd networkfabric nni update-bfd-administrative-state update parameter network_fabric_name: updated property options from ['--network-fabric-name'] to ['--fabric', '--fabric-name', '--network-fabric-name']
⚠️ 1010 - ParaPropUpdate networkfabric nni update-bfd-administrative-state cmd networkfabric nni update-bfd-administrative-state update parameter network_to_network_interconnect_name: updated property options from ['--network-to-network-interconnect-name', '--nni-name'] to ['--network-to-network-interconnect-name', '--nni-name', '--resource-name']
⚠️ 1001 - CmdAdd networkfabric nni update-npb-static-route-bfd-administrative-state cmd networkfabric nni update-npb-static-route-bfd-administrative-state added
⚠️ 1010 - ParaPropUpdate networkfabric nni wait cmd networkfabric nni wait update parameter fabric_name: updated property name from fabric_name to network_fabric_name
⚠️ 1010 - ParaPropUpdate networkfabric nni wait cmd networkfabric nni wait update parameter fabric_name: updated property options from ['--fabric', '--fabric-name'] to ['--fabric', '--fabric-name', '--network-fabric-name']
⚠️ 1006 - ParaAdd networkfabric tap create cmd networkfabric tap create added parameter mi_system_assigned
⚠️ 1006 - ParaAdd networkfabric tap create cmd networkfabric tap create added parameter mi_user_assigned
⚠️ 1010 - ParaPropUpdate networkfabric tap resync cmd networkfabric tap resync update parameter network_tap_name: updated property options from ['--network-tap-name'] to ['--network-tap-name', '--resource-name']
⚠️ 1006 - ParaAdd networkfabric tap update cmd networkfabric tap update added parameter mi_system_assigned
⚠️ 1006 - ParaAdd networkfabric tap update cmd networkfabric tap update added parameter mi_user_assigned
⚠️ 1006 - ParaAdd networkfabric taprule create cmd networkfabric taprule create added parameter identity_selector
⚠️ 1006 - ParaAdd networkfabric taprule create cmd networkfabric taprule create added parameter mi_system_assigned
⚠️ 1006 - ParaAdd networkfabric taprule create cmd networkfabric taprule create added parameter mi_user_assigned
⚠️ 1009 - ParaPropRemove networkfabric taprule create cmd networkfabric taprule create update parameter polling_interval_in_seconds: removed property choices=['120', '30', '60', '90']
⚠️ 1006 - ParaAdd networkfabric taprule update cmd networkfabric taprule update added parameter identity_selector
⚠️ 1006 - ParaAdd networkfabric taprule update cmd networkfabric taprule update added parameter mi_system_assigned
⚠️ 1006 - ParaAdd networkfabric taprule update cmd networkfabric taprule update added parameter mi_user_assigned

@azure-client-tools-bot-prd
Copy link

Hi @idanielsteven,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 4, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

github-actions bot commented Aug 4, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the managed network fabric extension to use the 2025-07-15 stable API version, migrating from the 2024-06-15-preview API. The update introduces new features, command arguments, and data structures, while maintaining compatibility with existing functionality.

Key changes include:

  • API version upgrade from 2024-06-15-preview to 2025-07-15 across all network fabric operations
  • Addition of new network fabric management commands for certificate and password rotation/synchronization
  • Enhanced schema definitions with improved operation status tracking and identity management features

Reviewed Changes

Copilot reviewed 90 out of 314 changed files in this pull request and generated no comments.

Show a summary per file
File Description
fabric/_rotate_certificate.py New command for rotating network fabric certificates
fabric/_resync_password.py New command for resynchronizing passwords across network devices
fabric/_resync_certificate.py New command for resynchronizing certificates across network devices
fabric/_provision.py Updated to use new API version with enhanced operation status response schema
fabric/_lock_fabric.py Updated API version and added resource-name parameter option
fabric/_list.py Enhanced with new properties like authorized transceiver, QoS configuration, and secret rotation status
fabric/_create.py Added support for feature flags, authorized transceiver, and QoS configuration
externalnetwork/_update_static_route_bfd_administrative_state.py New command for updating static route BFD administrative state
device/identity/* New identity management commands for network devices
Comments suppressed due to low confidence (5)

src/managednetworkfabric/azext_managednetworkfabric/aaz/latest/networkfabric/fabric/_rotate_certificate.py:22

  • The API version "2025-07-15" may not exist. As of my knowledge cutoff in January 2025, this future-dated API version should be verified to ensure it's available and stable.
        "version": "2025-07-15",

src/managednetworkfabric/azext_managednetworkfabric/aaz/latest/networkfabric/fabric/_resync_password.py:22

  • The API version "2025-07-15" may not exist. As of my knowledge cutoff in January 2025, this future-dated API version should be verified to ensure it's available and stable.
        "version": "2025-07-15",

src/managednetworkfabric/azext_managednetworkfabric/aaz/latest/networkfabric/fabric/_resync_certificate.py:22

  • The API version "2025-07-15" may not exist. As of my knowledge cutoff in January 2025, this future-dated API version should be verified to ensure it's available and stable.
        "version": "2025-07-15",

src/managednetworkfabric/azext_managednetworkfabric/aaz/latest/networkfabric/externalnetwork/_update_static_route_bfd_administrative_state.py:22

  • The API version "2025-07-15" may not exist. As of my knowledge cutoff in January 2025, this future-dated API version should be verified to ensure it's available and stable.
        "version": "2025-07-15",

src/managednetworkfabric/azext_managednetworkfabric/aaz/latest/networkfabric/device/identity/_show.py:22

  • The API version "2025-07-15" may not exist. As of my knowledge cutoff in January 2025, this future-dated API version should be verified to ensure it's available and stable.
        "version": "2025-07-15",

@github-actions
Copy link

github-actions bot commented Aug 4, 2025

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link

github-actions bot commented Aug 4, 2025

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Aug 4, 2025
@idanielsteven
Copy link
Contributor Author

❌Azure CLI Extensions Breaking Change Test

retry

@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot Network

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants