Skip to content

Conversation

@zjpjack-github
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

aks machine show
aks machine list

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings August 5, 2025 06:14
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Aug 5, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @zjpjack-github,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 5, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

github-actions bot commented Aug 5, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the aks machine show and aks machine list commands to display more comprehensive machine details beyond just IP addresses and hostnames. The changes improve user visibility into machine properties and correct documentation inconsistencies.

  • Expands machine output to include additional fields like zones, node image version, provisioning state, VM size, priority, mode, OS type, OS SKU, and FIPS enablement
  • Updates help documentation to reflect the broader scope of information now provided by these commands
  • Adds test assertions to verify the new fields are properly returned

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
_format.py Adds additional machine properties to the output formatter for more detailed information display
_help.py Updates command descriptions and fixes typos in help documentation
test_aks_commands.py Adds test assertions for provisioning state and OS type fields

@github-actions
Copy link

github-actions bot commented Aug 5, 2025

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Queued live test to validate the change, test passed!

  • test_aks_machine_cmds

@yanzhudd yanzhudd changed the title show more details for aks machine show/list [AKS] az aks machine show/list: Show more details Aug 8, 2025
@yanzhudd yanzhudd merged commit e264092 into Azure:main Aug 8, 2025
24 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Aug 8, 2025

[Release] Update index.json for extension [ aks-preview-18.0.0b25 ] : https://dev.azure.com/msazure/One/_build/results?buildId=133119076&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants