Skip to content

Conversation

@Jing-song
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings August 5, 2025 10:26
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Aug 5, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 5, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an Azure resource SDK import error in the acrcssc extension by updating the import path and bumping the minimum CLI version requirement.

  • Corrects the import path from azure.mgmt.resource.resources.models to azure.mgmt.resource.deployments.models
  • Updates the minimum CLI version requirement from 2.60.0 to 2.76.0
  • Increments the extension version to 1.0.0b4

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
setup.py Version bump to 1.0.0b4
_deployment.py Fixes import path for Azure resource deployment models
azext_metadata.json Updates minimum CLI core version requirement
HISTORY.rst Documents the SDK import fix in release notes

from azure.cli.core.azclierror import AzCLIError
from azure.cli.core.commands import LongRunningOperation
from azure.mgmt.resource.resources.models import (
from azure.mgmt.resource.deployments.models import (
Copy link

Copilot AI Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When working with Azure SDK imports, ensure this import path aligns with Azure best practices for the target CLI version. The change from 'resources.models' to 'deployments.models' should be verified against the Azure SDK documentation for version 2.76.0.

Copilot generated this review using guidance from repository custom instructions.
@github-actions
Copy link

github-actions bot commented Aug 5, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link

github-actions bot commented Aug 5, 2025

@kairu-ms kairu-ms merged commit edb8170 into Azure:main Aug 6, 2025
26 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Aug 6, 2025

[Release] Update index.json for extension [ acrcssc-1.0.0b4 ] : https://dev.azure.com/msazure/One/_build/results?buildId=132831310&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants