-
Notifications
You must be signed in to change notification settings - Fork 1.5k
{Acrcssc} Fix resource SDK import error #9041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes an Azure resource SDK import error in the acrcssc extension by updating the import path and bumping the minimum CLI version requirement.
- Corrects the import path from
azure.mgmt.resource.resources.modelstoazure.mgmt.resource.deployments.models - Updates the minimum CLI version requirement from 2.60.0 to 2.76.0
- Increments the extension version to 1.0.0b4
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| setup.py | Version bump to 1.0.0b4 |
| _deployment.py | Fixes import path for Azure resource deployment models |
| azext_metadata.json | Updates minimum CLI core version requirement |
| HISTORY.rst | Documents the SDK import fix in release notes |
| from azure.cli.core.azclierror import AzCLIError | ||
| from azure.cli.core.commands import LongRunningOperation | ||
| from azure.mgmt.resource.resources.models import ( | ||
| from azure.mgmt.resource.deployments.models import ( |
Copilot
AI
Aug 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When working with Azure SDK imports, ensure this import path aligns with Azure best practices for the target CLI version. The change from 'resources.models' to 'deployments.models' should be verified against the Azure SDK documentation for version 2.76.0.
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
|
[Release] Update index.json for extension [ acrcssc-1.0.0b4 ] : https://dev.azure.com/msazure/One/_build/results?buildId=132831310&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.