Skip to content

Conversation

@idanielsteven
Copy link
Contributor

@idanielsteven idanielsteven commented Aug 5, 2025

  • Updating managednetworkfabric CLI version 8-beta to stable cli version 8.x for 2024-06-15-preview.
  • Updating the networkcloud and networkfabric service names in the service_name.json and Readme.md's.

NOTE: As networkfabric and networkcloud CLI's are apart of the same organization and maintained by the same CLI dev team - this PR attempts to fix the 'service name' entries for both CLI's.


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings August 5, 2025 22:08
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Aug 5, 2025

⚠️Azure CLI Extensions Breaking Change Test
⚠️managednetworkfabric
rule cmd_name rule_message suggest_message
⚠️ 1010 - ParaPropUpdate networkfabric externalnetwork update-bfd-administrative-state cmd networkfabric externalnetwork update-bfd-administrative-state update parameter external_network_name: updated property options from ['--external-network-name'] to ['--external-network-name', '--resource-name']
⚠️ 1010 - ParaPropUpdate networkfabric fabric arm-configuration-diff cmd networkfabric fabric arm-configuration-diff update parameter network_fabric_name: updated property options from ['--network-fabric-name'] to ['--network-fabric-name', '--resource-name']
⚠️ 1010 - ParaPropUpdate networkfabric fabric commit-batch-status cmd networkfabric fabric commit-batch-status update parameter network_fabric_name: updated property options from ['--network-fabric-name'] to ['--network-fabric-name', '--resource-name']
⚠️ 1010 - ParaPropUpdate networkfabric fabric discard-commit-batch cmd networkfabric fabric discard-commit-batch update parameter network_fabric_name: updated property options from ['--network-fabric-name'] to ['--network-fabric-name', '--resource-name']
⚠️ 1010 - ParaPropUpdate networkfabric fabric identity assign cmd networkfabric fabric identity assign update parameter network_fabric_name: updated property options from ['--name', '--network-fabric-name', '-n'] to ['--name', '--network-fabric-name', '--resource-name', '-n']
⚠️ 1010 - ParaPropUpdate networkfabric fabric identity remove cmd networkfabric fabric identity remove update parameter network_fabric_name: updated property options from ['--name', '--network-fabric-name', '-n'] to ['--name', '--network-fabric-name', '--resource-name', '-n']
⚠️ 1010 - ParaPropUpdate networkfabric fabric identity show cmd networkfabric fabric identity show update parameter network_fabric_name: updated property options from ['--name', '--network-fabric-name', '-n'] to ['--name', '--network-fabric-name', '--resource-name', '-n']
⚠️ 1010 - ParaPropUpdate networkfabric fabric identity wait cmd networkfabric fabric identity wait update parameter network_fabric_name: updated property options from ['--name', '--network-fabric-name', '-n'] to ['--name', '--network-fabric-name', '--resource-name', '-n']
⚠️ 1010 - ParaPropUpdate networkfabric fabric lock-fabric cmd networkfabric fabric lock-fabric update parameter network_fabric_name: updated property options from ['--network-fabric-name'] to ['--network-fabric-name', '--resource-name']
⚠️ 1010 - ParaPropUpdate networkfabric fabric view-device-configuration cmd networkfabric fabric view-device-configuration update parameter network_fabric_name: updated property options from ['--network-fabric-name'] to ['--network-fabric-name', '--resource-name']
⚠️ 1010 - ParaPropUpdate networkfabric nni update-bfd-administrative-state cmd networkfabric nni update-bfd-administrative-state update parameter network_to_network_interconnect_name: updated property options from ['--network-to-network-interconnect-name', '--nni-name'] to ['--network-to-network-interconnect-name', '--nni-name', '--resource-name']
⚠️ 1010 - ParaPropUpdate networkfabric tap resync cmd networkfabric tap resync update parameter network_tap_name: updated property options from ['--network-tap-name'] to ['--network-tap-name', '--resource-name']

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 5, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

github-actions bot commented Aug 5, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the managednetworkfabric CLI extension from version 8-beta to stable version 8.0.0 for the 2024-06-15-preview API. The primary changes include parameter name standardization, minimum CLI version requirement updates, and the removal of unsupported identity commands.

Key changes:

  • Updates version from 8.0.0b7 to 8.0.0 in setup.py
  • Adds --resource-name parameter option to maintain consistency across commands
  • Removes unsupported network fabric identity commands

Reviewed Changes

Copilot reviewed 26 out of 26 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
setup.py Updates extension version from beta to stable
azext_metadata.json Increases minimum CLI core version requirement
test files Updates test commands to use new parameter names and adds test scenarios
aaz files Adds --resource-name parameter options for consistency
fabric identity files Removes entire identity command group due to lack of API support
HISTORY.rst Documents the changes in this release

@github-actions
Copy link

github-actions bot commented Aug 5, 2025

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link

github-actions bot commented Aug 5, 2025

Hi @idanielsteven

⚠️ Release Requirements

Module: managednetworkfabric

  • ⚠️ Please update VERSION to be 8.0.0b8 in src/managednetworkfabric/setup.py
  • ⚠️ Set azext.isPreview to true in azext_metadata.json for managednetworkfabric

Module: networkcloud

  • Please log updates into to src/networkcloud/HISTORY.rst
  • Update VERSION to 3.0.1 in src/networkcloud/setup.py

Notes

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Aug 5, 2025
@idanielsteven
Copy link
Contributor Author

Hi @idanielsteven

⚠️ Release Requirements

Module: managednetworkfabric

  • ⚠️ Please update VERSION to be 8.0.0b8 in src/managednetworkfabric/setup.py
  • ⚠️ Set azext.isPreview to true in azext_metadata.json for managednetworkfabric

Notes

This is going to stable CLI. -> 8.0.0. Please dis-regard.

@necusjz necusjz added skip-cal-version and removed release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. labels Aug 12, 2025
@necusjz necusjz merged commit 2604bb7 into Azure:main Aug 12, 2025
35 of 36 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ managednetworkfabric-8.0.0 ] : https://dev.azure.com/msazure/One/_build/results?buildId=133520930&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants