-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Updating managednetworkfabric CLI version 8-beta to stable cli version 8.x for 2024-06-15-preview. #9042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| networkfabric externalnetwork update-bfd-administrative-state | cmd networkfabric externalnetwork update-bfd-administrative-state update parameter external_network_name: updated property options from ['--external-network-name'] to ['--external-network-name', '--resource-name'] |
||
| networkfabric fabric arm-configuration-diff | cmd networkfabric fabric arm-configuration-diff update parameter network_fabric_name: updated property options from ['--network-fabric-name'] to ['--network-fabric-name', '--resource-name'] |
||
| networkfabric fabric commit-batch-status | cmd networkfabric fabric commit-batch-status update parameter network_fabric_name: updated property options from ['--network-fabric-name'] to ['--network-fabric-name', '--resource-name'] |
||
| networkfabric fabric discard-commit-batch | cmd networkfabric fabric discard-commit-batch update parameter network_fabric_name: updated property options from ['--network-fabric-name'] to ['--network-fabric-name', '--resource-name'] |
||
| networkfabric fabric identity assign | cmd networkfabric fabric identity assign update parameter network_fabric_name: updated property options from ['--name', '--network-fabric-name', '-n'] to ['--name', '--network-fabric-name', '--resource-name', '-n'] |
||
| networkfabric fabric identity remove | cmd networkfabric fabric identity remove update parameter network_fabric_name: updated property options from ['--name', '--network-fabric-name', '-n'] to ['--name', '--network-fabric-name', '--resource-name', '-n'] |
||
| networkfabric fabric identity show | cmd networkfabric fabric identity show update parameter network_fabric_name: updated property options from ['--name', '--network-fabric-name', '-n'] to ['--name', '--network-fabric-name', '--resource-name', '-n'] |
||
| networkfabric fabric identity wait | cmd networkfabric fabric identity wait update parameter network_fabric_name: updated property options from ['--name', '--network-fabric-name', '-n'] to ['--name', '--network-fabric-name', '--resource-name', '-n'] |
||
| networkfabric fabric lock-fabric | cmd networkfabric fabric lock-fabric update parameter network_fabric_name: updated property options from ['--network-fabric-name'] to ['--network-fabric-name', '--resource-name'] |
||
| networkfabric fabric view-device-configuration | cmd networkfabric fabric view-device-configuration update parameter network_fabric_name: updated property options from ['--network-fabric-name'] to ['--network-fabric-name', '--resource-name'] |
||
| networkfabric nni update-bfd-administrative-state | cmd networkfabric nni update-bfd-administrative-state update parameter network_to_network_interconnect_name: updated property options from ['--network-to-network-interconnect-name', '--nni-name'] to ['--network-to-network-interconnect-name', '--nni-name', '--resource-name'] |
||
| networkfabric tap resync | cmd networkfabric tap resync update parameter network_tap_name: updated property options from ['--network-tap-name'] to ['--network-tap-name', '--resource-name'] |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the managednetworkfabric CLI extension from version 8-beta to stable version 8.0.0 for the 2024-06-15-preview API. The primary changes include parameter name standardization, minimum CLI version requirement updates, and the removal of unsupported identity commands.
Key changes:
- Updates version from 8.0.0b7 to 8.0.0 in setup.py
- Adds
--resource-nameparameter option to maintain consistency across commands - Removes unsupported network fabric identity commands
Reviewed Changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| setup.py | Updates extension version from beta to stable |
| azext_metadata.json | Increases minimum CLI core version requirement |
| test files | Updates test commands to use new parameter names and adds test scenarios |
| aaz files | Adds --resource-name parameter options for consistency |
| fabric identity files | Removes entire identity command group due to lack of API support |
| HISTORY.rst | Documents the changes in this release |
...agednetworkfabric/azext_managednetworkfabric/tests/latest/test_nni_update_bfd_admin_state.py
Outdated
Show resolved
Hide resolved
...agednetworkfabric/azext_managednetworkfabric/tests/latest/test_nni_update_bfd_admin_state.py
Outdated
Show resolved
Hide resolved
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
This is going to stable CLI. -> 8.0.0. Please dis-regard. |
|
[Release] Update index.json for extension [ managednetworkfabric-8.0.0 ] : https://dev.azure.com/msazure/One/_build/results?buildId=133520930&view=results |
NOTE: As networkfabric and networkcloud CLI's are apart of the same organization and maintained by the same CLI dev team - this PR attempts to fix the 'service name' entries for both CLI's.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.