-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[k8s-extension] Update extension CLI to v1.6.7 #9043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[k8s-extension] Update extension CLI to v1.6.7 #9043
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the k8s-extension CLI from version 1.6.6 to 1.6.7, adding support for high log scale mode in the ContainerInsights extension. The key change introduces functionality to handle high-volume logging scenarios through enhanced data collection rules and endpoints.
- Adds high log scale mode support for ContainerInsights with configurable streams and data collection endpoints
- Implements proper cleanup logic for data collection rules and endpoints during extension deletion
- Updates extension version and history documentation
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/k8s-extension/setup.py | Version bump from 1.6.6 to 1.6.7 |
| src/k8s-extension/azext_k8s_extension/partner_extensions/ContainerInsights.py | Core implementation of high log scale mode with DCR/DCE management and cleanup logic |
| src/k8s-extension/HISTORY.rst | Documentation of changes in version 1.6.7 |
src/k8s-extension/azext_k8s_extension/partner_extensions/ContainerInsights.py
Show resolved
Hide resolved
src/k8s-extension/azext_k8s_extension/partner_extensions/ContainerInsights.py
Show resolved
Hide resolved
src/k8s-extension/azext_k8s_extension/partner_extensions/ContainerInsights.py
Show resolved
Hide resolved
src/k8s-extension/azext_k8s_extension/partner_extensions/ContainerInsights.py
Show resolved
Hide resolved
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
We have set up live tests in our forked repository as a continuous integration (CI) check and those tests include coverage for all these changes. All the tests can be found here: As the code owners of this extension CLI, we mandate that all changes be first made in our forked repository to ensure they undergo our comprehensive test suite |
|
|
Please fix CI issues |
Looking at the style CI test, it is not mandatory. We're actively working on resolving them, but it's an ongoing process due to the large number of style errors inherited from legacy code. |
|
Could you please add some test cases for these PR change? |
We have set up live tests in our forked repository as a continuous integration (CI) check and those tests include coverage for all these changes. All the tests can be found here: As the code owners of this extension CLI, we mandate that all changes be first made in our forked repository to ensure they undergo our comprehensive test suite |
|
[Release] Update index.json for extension [ k8s-extension-1.6.7 ] : https://dev.azure.com/msazure/One/_build/results?buildId=132983126&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.