Skip to content

Conversation

@bavneetsingh16
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings August 6, 2025 19:19
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Aug 6, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 6, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

github-actions bot commented Aug 6, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the k8s-extension CLI from version 1.6.6 to 1.6.7, adding support for high log scale mode in the ContainerInsights extension. The key change introduces functionality to handle high-volume logging scenarios through enhanced data collection rules and endpoints.

  • Adds high log scale mode support for ContainerInsights with configurable streams and data collection endpoints
  • Implements proper cleanup logic for data collection rules and endpoints during extension deletion
  • Updates extension version and history documentation

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
src/k8s-extension/setup.py Version bump from 1.6.6 to 1.6.7
src/k8s-extension/azext_k8s_extension/partner_extensions/ContainerInsights.py Core implementation of high log scale mode with DCR/DCE management and cleanup logic
src/k8s-extension/HISTORY.rst Documentation of changes in version 1.6.7

@github-actions
Copy link

github-actions bot commented Aug 6, 2025

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@bavneetsingh16
Copy link
Contributor Author

We have set up live tests in our forked repository as a continuous integration (CI) check and those tests include coverage for all these changes. All the tests can be found here:
https://github.com/AzureArcForKubernetes/k8s-extension/tree/main/testing/test/extensions/public

As the code owners of this extension CLI, we mandate that all changes be first made in our forked repository to ensure they undergo our comprehensive test suite

@github-actions
Copy link

github-actions bot commented Aug 6, 2025

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 6, 2025

Please fix CI issues

@bavneetsingh16
Copy link
Contributor Author

bavneetsingh16 commented Aug 7, 2025

Please fix CI issues

Looking at the style CI test, it is not mandatory. We're actively working on resolving them, but it's an ongoing process due to the large number of style errors inherited from legacy code.

@zhoxing-ms
Copy link
Contributor

Could you please add some test cases for these PR change?

@bavneetsingh16
Copy link
Contributor Author

Could you please add some test cases for these PR change?

We have set up live tests in our forked repository as a continuous integration (CI) check and those tests include coverage for all these changes. All the tests can be found here:
https://github.com/AzureArcForKubernetes/k8s-extension/tree/main/testing/test/extensions/public

As the code owners of this extension CLI, we mandate that all changes be first made in our forked repository to ensure they undergo our comprehensive test suite

@zhoxing-ms zhoxing-ms merged commit 18dcdfb into Azure:main Aug 7, 2025
29 of 32 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Aug 7, 2025

[Release] Update index.json for extension [ k8s-extension-1.6.7 ] : https://dev.azure.com/msazure/One/_build/results?buildId=132983126&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants