Skip to content

Conversation

@t0rr3sp3dr0
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

  • az aks create --subscription="${SUBSCRIPTION_ID}" --resource-group="${RESOURCEGROUP_NAME}" --location="${AZURE_LOCATION}" --name="${CLUSTER_NAME}" --kubernetes-version="${KUBERNETES_VERSION}" --enable-upstream-kubescheduler-user-configuration

  • az aks update --subscription="${SUBSCRIPTION_ID}" --resource-group="${RESOURCEGROUP_NAME}" --name="${CLUSTER_NAME}" --enable-upstream-kubescheduler-user-configuration

  • az aks update --subscription="${SUBSCRIPTION_ID}" --resource-group="${RESOURCEGROUP_NAME}" --name="${CLUSTER_NAME}" --disable-upstream-kubescheduler-user-configuration

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings August 19, 2025 02:21
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Aug 19, 2025

⚠️Azure CLI Extensions Breaking Change Test
⚠️aks-preview
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd aks create cmd aks create added parameter enable_upstream_kubescheduler_user_configuration
⚠️ 1006 - ParaAdd aks update cmd aks update added parameter disable_upstream_kubescheduler_user_configuration
⚠️ 1006 - ParaAdd aks update cmd aks update added parameter enable_upstream_kubescheduler_user_configuration

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 19, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements enable/disable flags for user-defined scheduler configuration in AKS clusters. It adds the ability to configure the kube-scheduler upstream to use custom CRD-based configuration instead of the default configuration.

  • Add support for enabling user-defined scheduler configuration during cluster creation and updates
  • Add support for disabling user-defined scheduler configuration during cluster updates
  • Implement mutual exclusivity validation to prevent conflicting enable/disable flags

Reviewed Changes

Copilot reviewed 9 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
setup.py Bumps extension version to 18.0.0b27
linter_exclusions.yml Adds exclusions for long option names for the new scheduler flags
test_managed_cluster_decorator.py Adds comprehensive unit tests for scheduler configuration functions
test_aks_commands.py Adds integration tests for create and update commands with scheduler flags
managed_cluster_decorator.py Implements core logic for scheduler profile configuration in create/update decorators
custom.py Adds new parameters to aks_create and aks_update function signatures
_params.py Defines CLI argument specifications for the new scheduler flags
_help.py Adds help documentation for the new scheduler configuration options
HISTORY.rst Documents the new feature in the changelog

@github-actions
Copy link

@t0rr3sp3dr0 t0rr3sp3dr0 force-pushed the pedrotorres/user-defined-scheduler-configuration branch from 206d3a4 to 1f15f63 Compare August 19, 2025 02:32
@t0rr3sp3dr0 t0rr3sp3dr0 force-pushed the pedrotorres/user-defined-scheduler-configuration branch from 1f15f63 to ba14196 Compare August 19, 2025 02:39
@FumingZhang
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Queued live test to validate the change, test passed!

  • test_aks_create_with_enable_upstream_kubescheduler_user_configuration
  • test_aks_update_with_enable_upstream_kubescheduler_user_configuration
  • test_aks_update_with_disable_upstream_kubescheduler_user_configuration

@FumingZhang
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@t0rr3sp3dr0
Copy link
Member Author

image

Live test succeeded! Please merge the PR when you have a chance, I don’t have permission to do so.

@yanzhudd yanzhudd merged commit 56da24a into Azure:main Aug 19, 2025
24 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ aks-preview-18.0.0b27 ] : https://dev.azure.com/msazure/One/_build/results?buildId=134296776&view=results

nilo19 pushed a commit to nilo19/azure-cli-extensions that referenced this pull request Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants