Skip to content

Conversation

@xmzhao0822
Copy link
Contributor


When adding a new node pool to an existed automatic cluster, we don't want to see annoying message: "The new node pool will enable SSH access, recommended to use ...."
We want to see warning message: SSH access is in preview

Related command

az aks create -g xm-rg -n xmauto --sku automatic
az aks nodepool add -g xm-rg --cluster-name xmauto --name userpool1 --node-count 1

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings August 23, 2025 05:03
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Aug 23, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @xmzhao0822,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 23, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Suppresses the annoying "enable SSH" message when adding a node pool to an existing automatic cluster and shows the appropriate preview warning instead.

  • Modifies SSH access warning logic to distinguish between automatic and non-automatic clusters
  • Updates the aks nodepool add command to pass cluster information to the decorator
  • Adds test coverage for the new behavior when adding node pools to automatic clusters

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File Description
src/aks-preview/azext_aks_preview/custom.py Retrieves managed cluster information and passes it to the agentpool decorator
src/aks-preview/azext_aks_preview/agentpool_decorator.py Updates SSH access setup to use cluster SKU information and show appropriate warnings
src/aks-preview/azext_aks_preview/tests/latest/test_agentpool_decorator.py Adds test case for SSH access warning behavior with automatic cluster SKU

@github-actions
Copy link

github-actions bot commented Aug 23, 2025

Hi @xmzhao0822

⚠️ Release Requirements

Module: aks-preview

  • ⚠️ Please update VERSION to be 18.0.0b29 in src/aks-preview/setup.py

Notes

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 23, 2025

Please fix CI issues

@xmzhao0822 xmzhao0822 changed the title {AKS} suppress enable ssh message when add nodepool to the existed automatic cluster {AKS} Suppress enable ssh message when adding a new nodepool to the existed automatic cluster Aug 25, 2025
@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Aug 26, 2025
@xmzhao0822 xmzhao0822 marked this pull request as draft August 26, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants