-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[fleet] Mark Gate commands as preview. #9081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| fleet gate approve | cmd fleet gate approve added property is_preview |
||
| fleet gate list | cmd fleet gate list added property is_preview |
||
| fleet gate show | cmd fleet gate show added property is_preview |
||
| fleet gate update | cmd fleet gate update added property is_preview |
|
Hi @dvadas, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR marks the Azure Fleet Gate commands as preview in the Azure CLI extension. The change adds the is_preview=True parameter to the command group definition to indicate that these commands are in preview status.
- Adds preview flag to the
fleet gatecommand group
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
Hi @dvadas Release SuggestionsModule: fleet
Notes
|
|
@kairu-ms we don't want this change to trigger a release. it's ok to bundle it with other changes that are coming. |
src/fleet/setup.py
Outdated
| # TODO: Confirm this is the right version number you want and it matches your | ||
| # HISTORY.rst entry. | ||
| VERSION = '1.6.2' | ||
| VERSION = '1.6.3' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only bump up this version number will trigger a release. So please remove this line change
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Please fix CI issues |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 9081 in repo Azure/azure-cli-extensions |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az fleet gate ...General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.