-
Notifications
You must be signed in to change notification settings - Fork 1.5k
{AKS} Refactor code to suppress ssh access warning message when creating an automatic cluster #9092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{AKS} Refactor code to suppress ssh access warning message when creating an automatic cluster #9092
Conversation
… automatic cluster
️✔️Azure CLI Extensions Breaking Change Test
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the SSH access warning logic to suppress warning messages when creating an automatic cluster. The change ensures that SSH access warnings are not displayed for automatic SKU clusters while maintaining warnings for base SKU clusters.
Key changes:
- Modified SSH access setup logic to conditionally show warnings based on cluster SKU type
- Updated test to reflect the new behavior where automatic clusters don't trigger SSH access warnings
- Added fallback logic for SKU name retrieval
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| setup.py | Version bump from 18.0.0b28 to 18.0.0b29 |
| test_aks_commands.py | Changed test location from eastus2 to eastasia |
| test_agentpool_decorator.py | Updated test to verify automatic clusters don't show SSH warnings |
| agentpool_decorator.py | Core logic changes to suppress SSH warnings for automatic clusters |
| HISTORY.rst | Added changelog entry for the refactoring |
|
|
The queued test passed, some warning messages but I think it's not related to my change. Queued |
|
Hi @FumingZhang could you please help to review the business logic? Thank you |
|
[Release] Update index.json for extension [ aks-preview-18.0.0b29 ] : https://dev.azure.com/msazure/One/_build/results?buildId=135432248&view=results |
Refactor code to suppress ssh access warning message when creating an automatic cluster
Related command
az aks create -g xm-rg -n xmmc --sku automatic
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.