-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[AKS] Add option AzureLinux3
to --os-sku
for az aks nodepool add
and az aks nodepool update
#9095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Calvin Shum <[email protected]>
- Add changelog entry for version 18.0.0b29 - Bump version to 18.0.0b29 - Follow exact pattern from Ubuntu2204/Ubuntu2404 implementation 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> Signed-off-by: Calvin Shum <[email protected]>
❌Azure CLI Extensions Breaking Change Test
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for the AzureLinux3
OS SKU option to the AKS nodepool commands. The change enables users to specify AzureLinux3
as an operating system SKU when adding or updating node pools in Azure Kubernetes Service clusters.
- Introduces the
AzureLinux3
constant and adds it to the allowed OS SKU lists for nodepool operations - Updates help documentation to reflect the new OS SKU option
- Adds comprehensive test coverage for the new functionality
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
setup.py | Bumps version from 18.0.0b28 to 18.0.0b29 for the new release |
_consts.py | Defines the new CONST_OS_SKU_AZURELINUX3 constant |
_params.py | Adds AzureLinux3 to the allowed OS SKU lists for create and update operations |
_help.py | Updates help text to include AzureLinux3 in the list of supported OS SKUs |
test_aks_commands.py | Adds test case to verify AzureLinux3 OS SKU functionality |
HISTORY.rst | Documents the new feature in the changelog |
@@ -1918,7 +1918,7 @@ | |||
short-summary: The OS Type. Linux or Windows. Windows not supported yet for "VirtualMachines" VM set type. | |||
- name: --os-sku | |||
type: string | |||
short-summary: The os-sku of the agent node pool. Ubuntu, CBLMariner, Ubuntu2204 or Ubuntu2404 when os-type is Linux, default is Ubuntu if not set; Windows2019, Windows2022 or WindowsAnnual when os-type is Windows, the current default is Windows2022 if not set. | |||
short-summary: The os-sku of the agent node pool. Ubuntu, Ubuntu2204, Ubuntu2404, CBLMariner, AzureLinux or AzureLinux3 when os-type is Linux, default is Ubuntu if not set; Windows2019, Windows2022 or WindowsAnnual when os-type is Windows, the current default is Windows2022 if not set. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The help text lists OS SKUs in an inconsistent order. Consider organizing them alphabetically or by release order for better readability. The current order is: Ubuntu, Ubuntu2204, Ubuntu2404, CBLMariner, AzureLinux, AzureLinux3.
short-summary: The os-sku of the agent node pool. Ubuntu, Ubuntu2204, Ubuntu2404, CBLMariner, AzureLinux or AzureLinux3 when os-type is Linux, default is Ubuntu if not set; Windows2019, Windows2022 or WindowsAnnual when os-type is Windows, the current default is Windows2022 if not set. | |
short-summary: The os-sku of the agent node pool. AzureLinux, AzureLinux3, CBLMariner, Ubuntu, Ubuntu2204, or Ubuntu2404 when os-type is Linux, default is Ubuntu if not set; Windows2019, Windows2022, or WindowsAnnual when os-type is Windows, the current default is Windows2022 if not set. |
Copilot uses AI. Check for mistakes.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix CI issues |
This reverts commit 588cb2a.
- Add changelog entry for version 18.0.0b34 - Bump version to 18.0.0b34
queued live test for test_aks_nodepool_add_with_ossku_azurelinux3 https://dev.azure.com/msazure/CloudNativeCompute/_build/results?buildId=135948025&view=results |
Could you please resolve these conflicts? |
3af6e28
I’ve resolved the conflict in this PR. The CI is currently failing, but it doesn’t appear to be related to my changes since I only bumped the version in the latest commit. |
CI failed with following error msg, as the previous change #9131 bumps the default API version, please update your recording file accordingly.
E AssertionError: Can't overwrite existing cassette ('/mnt/vss/_work/1/s/src/aks-preview/azext_aks_preview/tests/latest/recordings/test_aks_nodepool_add_with_ossku_azurelinux3.yaml') in your current record mode ('once'). |
Could you please resolve these CI issues? |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks nodepool add
az aks nodepool update
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.