Skip to content

Conversation

calvin197
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks nodepool add
az aks nodepool update

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

anujmaheshwari1 and others added 4 commits August 26, 2025 14:27
- Add changelog entry for version 18.0.0b29
- Bump version to 18.0.0b29
- Follow exact pattern from Ubuntu2204/Ubuntu2404 implementation

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
Signed-off-by: Calvin Shum <[email protected]>
@Copilot Copilot AI review requested due to automatic review settings August 26, 2025 22:59
Copy link

azure-client-tools-bot-prd bot commented Aug 26, 2025

❌Azure CLI Extensions Breaking Change Test
❌aks-preview
rule cmd_name rule_message suggest_message
1010 - ParaPropUpdate aks nodepool add cmd aks nodepool add update parameter spot_max_price: updated property default from nan to nan please change property default from nan to nan for parameter spot_max_price of cmd aks nodepool add
⚠️ 1010 - ParaPropUpdate aks create cmd aks create update parameter os_sku: updated property choices from ['AzureLinux', 'CBLMariner', 'Mariner', 'Ubuntu', 'Ubuntu2204', 'Ubuntu2404'] to ['AzureLinux', 'AzureLinux3', 'CBLMariner', 'Mariner', 'Ubuntu', 'Ubuntu2204', 'Ubuntu2404']
⚠️ 1010 - ParaPropUpdate aks nodepool add cmd aks nodepool add update parameter os_sku: updated property choices from ['AzureLinux', 'CBLMariner', 'Mariner', 'Ubuntu', 'Ubuntu2204', 'Ubuntu2404', 'Windows2019', 'Windows2022', 'WindowsAnnual'] to ['AzureLinux', 'AzureLinux3', 'CBLMariner', 'Mariner', 'Ubuntu', 'Ubuntu2204', 'Ubuntu2404', 'Windows2019', 'Windows2022', 'WindowsAnnual']
⚠️ 1010 - ParaPropUpdate aks nodepool update cmd aks nodepool update update parameter os_sku: updated property choices from ['AzureLinux', 'Ubuntu', 'Ubuntu2204', 'Ubuntu2404'] to ['AzureLinux', 'AzureLinux3', 'Ubuntu', 'Ubuntu2204', 'Ubuntu2404']

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 26, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for the AzureLinux3 OS SKU option to the AKS nodepool commands. The change enables users to specify AzureLinux3 as an operating system SKU when adding or updating node pools in Azure Kubernetes Service clusters.

  • Introduces the AzureLinux3 constant and adds it to the allowed OS SKU lists for nodepool operations
  • Updates help documentation to reflect the new OS SKU option
  • Adds comprehensive test coverage for the new functionality

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
setup.py Bumps version from 18.0.0b28 to 18.0.0b29 for the new release
_consts.py Defines the new CONST_OS_SKU_AZURELINUX3 constant
_params.py Adds AzureLinux3 to the allowed OS SKU lists for create and update operations
_help.py Updates help text to include AzureLinux3 in the list of supported OS SKUs
test_aks_commands.py Adds test case to verify AzureLinux3 OS SKU functionality
HISTORY.rst Documents the new feature in the changelog

@@ -1918,7 +1918,7 @@
short-summary: The OS Type. Linux or Windows. Windows not supported yet for "VirtualMachines" VM set type.
- name: --os-sku
type: string
short-summary: The os-sku of the agent node pool. Ubuntu, CBLMariner, Ubuntu2204 or Ubuntu2404 when os-type is Linux, default is Ubuntu if not set; Windows2019, Windows2022 or WindowsAnnual when os-type is Windows, the current default is Windows2022 if not set.
short-summary: The os-sku of the agent node pool. Ubuntu, Ubuntu2204, Ubuntu2404, CBLMariner, AzureLinux or AzureLinux3 when os-type is Linux, default is Ubuntu if not set; Windows2019, Windows2022 or WindowsAnnual when os-type is Windows, the current default is Windows2022 if not set.
Copy link
Preview

Copilot AI Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The help text lists OS SKUs in an inconsistent order. Consider organizing them alphabetically or by release order for better readability. The current order is: Ubuntu, Ubuntu2204, Ubuntu2404, CBLMariner, AzureLinux, AzureLinux3.

Suggested change
short-summary: The os-sku of the agent node pool. Ubuntu, Ubuntu2204, Ubuntu2404, CBLMariner, AzureLinux or AzureLinux3 when os-type is Linux, default is Ubuntu if not set; Windows2019, Windows2022 or WindowsAnnual when os-type is Windows, the current default is Windows2022 if not set.
short-summary: The os-sku of the agent node pool. AzureLinux, AzureLinux3, CBLMariner, Ubuntu, Ubuntu2204, or Ubuntu2404 when os-type is Linux, default is Ubuntu if not set; Windows2019, Windows2022, or WindowsAnnual when os-type is Windows, the current default is Windows2022 if not set.

Copilot uses AI. Check for mistakes.

Copy link

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Queued live test to validate the change.

  • test_aks_nodepool_add_with_ossku_azurelinux3

@calvin197 calvin197 requested a review from FumingZhang August 28, 2025 23:28
FumingZhang
FumingZhang previously approved these changes Aug 29, 2025
@yonzhan
Copy link
Collaborator

yonzhan commented Aug 29, 2025

Please fix CI issues

@calvin197
Copy link
Contributor Author

queued live test for test_aks_nodepool_add_with_ossku_azurelinux3

https://dev.azure.com/msazure/CloudNativeCompute/_build/results?buildId=135948025&view=results

FumingZhang
FumingZhang previously approved these changes Sep 4, 2025
zhoxing-ms
zhoxing-ms previously approved these changes Sep 4, 2025
@zhoxing-ms
Copy link
Contributor

Could you please resolve these conflicts?

@calvin197 calvin197 dismissed stale reviews from zhoxing-ms and FumingZhang via 3af6e28 September 4, 2025 17:51
@calvin197
Copy link
Contributor Author

calvin197 commented Sep 4, 2025

I’ve resolved the conflict in this PR. The CI is currently failing, but it doesn’t appear to be related to my changes since I only bumped the version in the latest commit.

@FumingZhang
Copy link
Member

CI failed with following error msg, as the previous change #9131 bumps the default API version, please update your recording file accordingly.

      raise AssertionError(ex)

E AssertionError: Can't overwrite existing cassette ('/mnt/vss/_work/1/s/src/aks-preview/azext_aks_preview/tests/latest/recordings/test_aks_nodepool_add_with_ossku_azurelinux3.yaml') in your current record mode ('once').
E No match for the request (<Request (PUT) https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest000001/providers/Microsoft.ContainerService/managedClusters/cliakstest000002?api-version=2025-07-02-preview>) was found.
E Found 1 similar requests with 1 different matcher(s) :
E
E 1 - (<Request (PUT) https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest000001/providers/Microsoft.ContainerService/managedClusters/cliakstest000002?api-version=2025-06-02-preview>)..)
E Matchers succeeded : ['method', 'scheme', 'host', 'port', 'path']
E Matchers failed :
E _custom_request_query_matcher - assertion failure :
E None

zhoxing-ms
zhoxing-ms previously approved these changes Sep 5, 2025
@zhoxing-ms
Copy link
Contributor

Could you please resolve these CI issues?

@FumingZhang
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants