Skip to content

Conversation

@sonalsingh-msft
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings August 28, 2025 00:25
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Aug 28, 2025

⚠️Azure CLI Extensions Breaking Change Test
⚠️network-manager
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd network manager connect-config create cmd network manager connect-config create added parameter connectivity_capabilities
⚠️ 1006 - ParaAdd network manager connect-config update cmd network manager connect-config update added parameter connectivity_capabilities

@azure-client-tools-bot-prd
Copy link

Hi @sonalsingh-msft,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 28, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Azure Network Manager connectivity configuration CLI to use API version 2024-07-01, adding support for the new connectivityCapabilities field and improving test coverage.

  • Updates API version from 2022-01-01 to 2024-07-01 across all connectivity configuration commands
  • Adds support for connectivity capabilities (address overlap, private endpoints scale, and peering enforcement)
  • Adds comprehensive test case for the new capabilities functionality

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
test_network_scenario.py Adds new test for connectivity capabilities and enables skipped tests
test_network_manager_connect_config_with_capabilities.yaml New test recording file for capabilities test
_create.py Adds connectivity-capabilities argument group with API version update
_update.py Adds connectivity-capabilities support for updates
_show.py Updates schema to include connectivity capabilities fields
_list.py Updates list command schema for new fields
_delete.py Updates API version for delete operations
_wait.py Updates wait command with new schema and API version
_list_effective_connectivity_config.py Updates effective config listing with new schema
_list_active_connectivity_config.py Updates active config listing with new schema

@github-actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link

github-actions bot commented Aug 28, 2025

Hi @sonalsingh-msft

⚠️ Release Requirements

Module: network-manager

  • ⚠️ Please update VERSION to be 3.0.0 in src/network-manager/setup.py

Notes

@necusjz
Copy link
Member

necusjz commented Aug 28, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Aug 28, 2025
@sonalsingh-msft sonalsingh-msft changed the title Update Azure Network Manager connectivity configuration CLI to use 2024-07-01 API version with full field support and comprehensive test coverage [Draft] Update Azure Network Manager connectivity configuration CLI to use 2024-07-01 API version with full field support and comprehensive test coverage Sep 5, 2025
@sonalsingh-msft sonalsingh-msft changed the title [Draft] Update Azure Network Manager connectivity configuration CLI to use 2024-07-01 API version with full field support and comprehensive test coverage [Old Draft] Update Azure Network Manager connectivity configuration CLI to use 2024-07-01 API version with full field support and comprehensive test coverage Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot Network - Network Manager Network release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants