-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[Old Draft] Update Azure Network Manager connectivity configuration CLI to use 2024-07-01 API version with full field support and comprehensive test coverage #9099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: jacrewe-msft <[email protected]>
…mand Co-authored-by: jacrewe-msft <[email protected]>
…-07-01 API Co-authored-by: jacrewe-msft <[email protected]>
…ity capabilities Co-authored-by: jacrewe-msft <[email protected]>
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| network manager connect-config create | cmd network manager connect-config create added parameter connectivity_capabilities |
||
| network manager connect-config update | cmd network manager connect-config update added parameter connectivity_capabilities |
|
Hi @sonalsingh-msft, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Azure Network Manager connectivity configuration CLI to use API version 2024-07-01, adding support for the new connectivityCapabilities field and improving test coverage.
- Updates API version from 2022-01-01 to 2024-07-01 across all connectivity configuration commands
- Adds support for connectivity capabilities (address overlap, private endpoints scale, and peering enforcement)
- Adds comprehensive test case for the new capabilities functionality
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test_network_scenario.py | Adds new test for connectivity capabilities and enables skipped tests |
| test_network_manager_connect_config_with_capabilities.yaml | New test recording file for capabilities test |
| _create.py | Adds connectivity-capabilities argument group with API version update |
| _update.py | Adds connectivity-capabilities support for updates |
| _show.py | Updates schema to include connectivity capabilities fields |
| _list.py | Updates list command schema for new fields |
| _delete.py | Updates API version for delete operations |
| _wait.py | Updates wait command with new schema and API version |
| _list_effective_connectivity_config.py | Updates effective config listing with new schema |
| _list_active_connectivity_config.py | Updates active config listing with new schema |
src/network-manager/azext_network_manager/tests/latest/test_network_scenario.py
Show resolved
Hide resolved
src/network-manager/azext_network_manager/tests/latest/test_network_scenario.py
Show resolved
Hide resolved
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.