Skip to content

Conversation

@nilo19
Copy link
Member

@nilo19 nilo19 commented Aug 28, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks agent

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Enhance the user experience of az aks agent, including:

  1. Use aks-mcp by default, offering an opt-out flag --no-aks-mcp.
  2. Disable duplicated built-in toolsets when using aks-mcp.
  3. Manage the lifecycle of aks-mcp binary, including downloading, updating, health checking and gracefully stopping.
  4. Offer --status to display the system status.
  5. Refine system prompt.
  6. Smart toolset refreshment when switching between mcp and traditional mode.

Copilot AI review requested due to automatic review settings August 28, 2025 04:00
@azure-client-tools-bot-prd
Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

@azure-client-tools-bot-prd
Copy link

Hi @nilo19,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 28, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the user experience of the az aks agent command by introducing MCP (Model Context Protocol) support as the default mode, adding a new --status flag for system monitoring, and improving the overall agent lifecycle management.

  • Introduces aks-mcp as the default mode with an opt-out flag --no-aks-mcp
  • Adds comprehensive status reporting via --status flag
  • Implements lifecycle management for MCP binary including downloading, updating, and health checking

Reviewed Changes

Copilot reviewed 27 out of 28 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
custom.py Adds new parameters and status command implementation
test_aks_agent_status_registration.py Tests for status command registration
test_user_feedback.py Tests for progress reporting and user feedback
test_mcp_manager.py Tests for MCP manager lifecycle operations
test_config_generator.py Tests for configuration generation
test_binary_manager.py Tests for binary management operations
test_aks_agent_status_models.py Tests for status data models
test_aks_agent_status_command.py Tests for status command functionality
test_aks_agent_status.py Tests for status collection logic
test_aks_agent_smart_refresh.py Tests for smart refresh strategy
test_aks_agent_parameters.py Tests for new parameter parsing
test_aks_agent_mcp_integration.py Tests for MCP integration functionality
test_aks_agent_error_handler.py Tests for enhanced error handling
user_feedback.py Progress reporting implementation
status_models.py Data models for status information
status.py Status collection and management logic

@github-actions
Copy link

github-actions bot commented Aug 28, 2025

@nilo19 nilo19 force-pushed the feat/aks-agent-ux-enhancement branch from 7bbac6f to fd8e833 Compare August 28, 2025 04:22
@nilo19 nilo19 closed this Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants