-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: User experience enhancement of az aks agent #9100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Hi @nilo19, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the user experience of the az aks agent command by introducing MCP (Model Context Protocol) support as the default mode, adding a new --status flag for system monitoring, and improving the overall agent lifecycle management.
- Introduces
aks-mcpas the default mode with an opt-out flag--no-aks-mcp - Adds comprehensive status reporting via
--statusflag - Implements lifecycle management for MCP binary including downloading, updating, and health checking
Reviewed Changes
Copilot reviewed 27 out of 28 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| custom.py | Adds new parameters and status command implementation |
| test_aks_agent_status_registration.py | Tests for status command registration |
| test_user_feedback.py | Tests for progress reporting and user feedback |
| test_mcp_manager.py | Tests for MCP manager lifecycle operations |
| test_config_generator.py | Tests for configuration generation |
| test_binary_manager.py | Tests for binary management operations |
| test_aks_agent_status_models.py | Tests for status data models |
| test_aks_agent_status_command.py | Tests for status command functionality |
| test_aks_agent_status.py | Tests for status collection logic |
| test_aks_agent_smart_refresh.py | Tests for smart refresh strategy |
| test_aks_agent_parameters.py | Tests for new parameter parsing |
| test_aks_agent_mcp_integration.py | Tests for MCP integration functionality |
| test_aks_agent_error_handler.py | Tests for enhanced error handling |
| user_feedback.py | Progress reporting implementation |
| status_models.py | Data models for status information |
| status.py | Status collection and management logic |
src/aks-preview/azext_aks_preview/tests/latest/test_user_feedback.py
Outdated
Show resolved
Hide resolved
src/aks-preview/azext_aks_preview/tests/latest/test_binary_manager.py
Outdated
Show resolved
Hide resolved
|
7bbac6f to
fd8e833
Compare
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks agent
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.Enhance the user experience of az aks agent, including:
--no-aks-mcp.--statusto display the system status.