Skip to content

Conversation

@Bickor
Copy link
Contributor

@Bickor Bickor commented Aug 28, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks

az aks nodepool add --cluster-name myAKSCluster --resource-group myResourceGroup --name nodepool2 --os-sku AzureLinux --workload-runtime KataVmIsolation --node-vm-size Standard_D4s_v3

az aks create --name myAKSCluster --resource-group myResourceGroup --os-sku AzureLinux --workload-runtime KataVmIsolation --node-vm-size Standard_D4s_v3 --node-count 1 --generate-ssh-keys

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Aug 28, 2025

❌Azure CLI Extensions Breaking Change Test
❌aks-preview
rule cmd_name rule_message suggest_message
1010 - ParaPropUpdate aks nodepool add cmd aks nodepool add update parameter spot_max_price: updated property default from nan to nan please change property default from nan to nan for parameter spot_max_price of cmd aks nodepool add
⚠️ 1010 - ParaPropUpdate aks create cmd aks create update parameter workload_runtime: updated property choices from ['KataCcIsolation', 'KataMshvVmIsolation', 'OCIContainer', 'WasmWasi'] to ['KataCcIsolation', 'KataMshvVmIsolation', 'KataVmIsolation', 'OCIContainer', 'WasmWasi']
⚠️ 1010 - ParaPropUpdate aks nodepool add cmd aks nodepool add update parameter workload_runtime: updated property choices from ['KataCcIsolation', 'KataMshvVmIsolation', 'OCIContainer', 'WasmWasi'] to ['KataCcIsolation', 'KataMshvVmIsolation', 'KataVmIsolation', 'OCIContainer', 'WasmWasi']

@azure-client-tools-bot-prd
Copy link

Hi @Bickor,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 28, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link

github-actions bot commented Aug 28, 2025

@yonzhan yonzhan requested review from yanzhudd and zhoxing-ms August 29, 2025 00:17
@Bickor Bickor force-pushed the mheberling/kataNameChange branch 2 times, most recently from c17f249 to c8d8eb5 Compare November 4, 2025 02:46
@Bickor Bickor marked this pull request as ready for review November 4, 2025 02:54
Copilot AI review requested due to automatic review settings November 4, 2025 02:54
@Bickor Bickor changed the title Modified kata to use new katavmisolation name. az command aks: Add KataVmIsolation workload runtime Nov 4, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR renames the Kata VM isolation workload runtime constant from KataMshvVmIsolation to KataVmIsolation while maintaining backward compatibility with the old name. The version is bumped to 19.0.0b10.

  • Introduced KataVmIsolation as the new preferred workload runtime value
  • Kept KataMshvVmIsolation as OLD_KATA_VM_ISOLATION for backward compatibility
  • Updated SDK enums and constants to support both values

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
setup.py Version bump to 19.0.0b10
_container_service_client_enums.py Reordered enum values to prioritize new KataVmIsolation and renamed old value with updated documentation
test_agentpool_decorator.py Added test methods for the new Kata VM isolation workload runtime
_params.py Updated imports and workload runtime list to include both new and old constants
_consts.py Added new constant for KataVmIsolation and renamed old constant to OLD_KATA_VM_ISOLATION
HISTORY.rst Added changelog entry for 19.0.0b10

@FumingZhang
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

WASM_WASI = "WasmWasi"
"""Nodes will use Krustlet to run WASM workloads using the WASI provider (Preview)."""
KATA_MSHV_VM_ISOLATION = "KataMshvVmIsolation"
KATA_VM_ISOLATION = "KataVmIsolation"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to update the SDK, it's auto generated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed change.

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a need to update the live test case to ensure that both the old and new enums function correctly?

@Bickor
Copy link
Contributor Author

Bickor commented Nov 4, 2025

Is there a need to update the live test case to ensure that both the old and new enums function correctly?

Added a test case for the old enum as well.

@FumingZhang
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Nov 5, 2025
@Bickor Bickor force-pushed the mheberling/kataNameChange branch from 2a67f58 to 59bf2fd Compare November 5, 2025 00:20
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Nov 5, 2025
@FumingZhang
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@AKSCustomResourceGroupPreparer(
random_name_length=17, name_prefix="clitest", location="westus2"
)
def test_aks_cluster_kata(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Queued live test to validate the change.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Live test failed with following error

          raise CLIError('An RSA key file or key value must be supplied to SSH Key Value. '
                           'You can use --generate-ssh-keys to let CLI generate one for you')

E knack.util.CLIError: An RSA key file or key value must be supplied to SSH Key Value. You can use --generate-ssh-keys to let CLI generate one for you

https://dev.azure.com/msazure/CloudNativeCompute/CloudNativeCompute%20Team/_build/results?buildId=142667237&view=logs&j=b162b355-d59d-5864-ce0f-0a70f12dd28b&t=a26fe913-e2be-5062-b08e-d15f1acc7ea2&l=3967

Please follow other cases as exmaples, and add "ssh_key_value": self.generate_ssh_keys(), to self.kwargs.update(, then create cluster with --ssh-key-value={ssh_key_value}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added!

Copy link
Member

@FumingZhang FumingZhang Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-queued live test, test passed!

@Bickor Bickor force-pushed the mheberling/kataNameChange branch from 100dc0b to c561da8 Compare November 5, 2025 02:25
@FumingZhang
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

but I think you'll need to commit the recording files for the newly added test cases to pass CI checks. You can find recordings generated by the live test from pipeline artifacts

@FumingZhang
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

FumingZhang
FumingZhang previously approved these changes Nov 5, 2025

Pending

19.0.0b11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please rebase from main and choose a new version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@FumingZhang
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@yanzhudd yanzhudd merged commit 8775a88 into Azure:main Nov 7, 2025
25 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Nov 7, 2025

[Release] Update index.json for extension [ aks-preview-19.0.0b12 ] : https://dev.azure.com/msazure/One/_build/results?buildId=142976980&view=results

@Bickor Bickor deleted the mheberling/kataNameChange branch November 7, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants