-
Notifications
You must be signed in to change notification settings - Fork 1.5k
az command aks: Add KataVmIsolation workload runtime
#9104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❌Azure CLI Extensions Breaking Change Test
|
|
Hi @Bickor, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
c17f249 to
c8d8eb5
Compare
az command aks: Add KataVmIsolation workload runtime
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR renames the Kata VM isolation workload runtime constant from KataMshvVmIsolation to KataVmIsolation while maintaining backward compatibility with the old name. The version is bumped to 19.0.0b10.
- Introduced
KataVmIsolationas the new preferred workload runtime value - Kept
KataMshvVmIsolationasOLD_KATA_VM_ISOLATIONfor backward compatibility - Updated SDK enums and constants to support both values
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| setup.py | Version bump to 19.0.0b10 |
| _container_service_client_enums.py | Reordered enum values to prioritize new KataVmIsolation and renamed old value with updated documentation |
| test_agentpool_decorator.py | Added test methods for the new Kata VM isolation workload runtime |
| _params.py | Updated imports and workload runtime list to include both new and old constants |
| _consts.py | Added new constant for KataVmIsolation and renamed old constant to OLD_KATA_VM_ISOLATION |
| HISTORY.rst | Added changelog entry for 19.0.0b10 |
src/aks-preview/azext_aks_preview/tests/latest/test_agentpool_decorator.py
Outdated
Show resolved
Hide resolved
src/aks-preview/azext_aks_preview/tests/latest/test_agentpool_decorator.py
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
| WASM_WASI = "WasmWasi" | ||
| """Nodes will use Krustlet to run WASM workloads using the WASI provider (Preview).""" | ||
| KATA_MSHV_VM_ISOLATION = "KataMshvVmIsolation" | ||
| KATA_VM_ISOLATION = "KataVmIsolation" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to update the SDK, it's auto generated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed change.
FumingZhang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a need to update the live test case to ensure that both the old and new enums function correctly?
Added a test case for the old enum as well. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
src/aks-preview/azext_aks_preview/tests/latest/test_agentpool_decorator.py
Outdated
Show resolved
Hide resolved
2a67f58 to
59bf2fd
Compare
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
| @AKSCustomResourceGroupPreparer( | ||
| random_name_length=17, name_prefix="clitest", location="westus2" | ||
| ) | ||
| def test_aks_cluster_kata( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Queued live test to validate the change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Live test failed with following error
raise CLIError('An RSA key file or key value must be supplied to SSH Key Value. ''You can use --generate-ssh-keys to let CLI generate one for you')E knack.util.CLIError: An RSA key file or key value must be supplied to SSH Key Value. You can use --generate-ssh-keys to let CLI generate one for you
Please follow other cases as exmaples, and add "ssh_key_value": self.generate_ssh_keys(), to self.kwargs.update(, then create cluster with --ssh-key-value={ssh_key_value}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-queued live test, test passed!
100dc0b to
c561da8
Compare
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
FumingZhang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
but I think you'll need to commit the recording files for the newly added test cases to pass CI checks. You can find recordings generated by the live test from pipeline artifacts
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
src/aks-preview/HISTORY.rst
Outdated
|
|
||
| Pending | ||
|
|
||
| 19.0.0b11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please rebase from main and choose a new version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
dab3ad4 to
4a90d93
Compare
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
[Release] Update index.json for extension [ aks-preview-19.0.0b12 ] : https://dev.azure.com/msazure/One/_build/results?buildId=142976980&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks
az aks nodepool add --cluster-name myAKSCluster --resource-group myResourceGroup --name nodepool2 --os-sku AzureLinux --workload-runtime KataVmIsolation --node-vm-size Standard_D4s_v3
az aks create --name myAKSCluster --resource-group myResourceGroup --os-sku AzureLinux --workload-runtime KataVmIsolation --node-vm-size Standard_D4s_v3 --node-count 1 --generate-ssh-keys
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.