Skip to content

Conversation

@mainred
Copy link
Member

@mainred mainred commented Aug 29, 2025


PR description

When installing aks-preview with agent on windows, it takes 6 minutes or more to install holmesgpt without detailed log, this impacts the user who use aks-preview not the agentic tool.
We want to remove this dependency from aks-preview to unblock aks-preview users. Alternatively, we can

  • introduce another extension aks-agent
  • manage the holmes binary in the agent
  • introduce a flag to init agent by installing the dependencies,

We can keep the agent in aks-preview with the last two options. But before we finalize the decision and PR, we use this PR to unblock aks-preview users.

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings August 29, 2025 02:43
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Aug 29, 2025

❌Azure CLI Extensions Breaking Change Test
❌aks-preview
rule cmd_name rule_message suggest_message
1002 - CmdRemove aks agent cmd aks agent removed please confirm cmd aks agent removed

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 29, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the AKS agent functionality from the aks-preview extension to address installation performance issues. The agent dependency (holmesgpt) was causing 6+ minute installation times on Windows without detailed logs, negatively impacting users who only needed the aks-preview extension.

  • Removes the holmesgpt dependency and all agent-related code
  • Updates version from 18.0.0b28 to 18.0.0b29
  • Cleans up commands, parameters, validators, and test files related to the agent

Reviewed Changes

Copilot reviewed 13 out of 14 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/aks-preview/setup.py Removes holmesgpt dependency and bumps version
src/aks-preview/azext_aks_preview/tests/latest/test_validators.py Removes agent config file validation tests
src/aks-preview/azext_aks_preview/tests/latest/test_agent.py Deletes entire agent test file
src/aks-preview/azext_aks_preview/custom.py Removes agent command implementation
src/aks-preview/azext_aks_preview/commands.py Removes agent command registration
src/aks-preview/azext_aks_preview/agent/*.py Deletes all agent implementation files
src/aks-preview/azext_aks_preview/_validators.py Removes agent config file validation functions
src/aks-preview/azext_aks_preview/_params.py Removes agent command parameters
src/aks-preview/azext_aks_preview/_help.py Removes agent command help documentation
src/aks-preview/azext_aks_preview/_consts.py Removes agent-related constants
src/aks-preview/HISTORY.rst Documents removal of the agent functionality

@github-actions
Copy link

FumingZhang
FumingZhang previously approved these changes Aug 29, 2025
@FumingZhang
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

@FumingZhang
Copy link
Member

please resolve merge conflicts

@mainred
Copy link
Member Author

mainred commented Aug 29, 2025

Just resolved the conflicts and bumped the version. Please help trigger pipeline run again.

@FumingZhang
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

FumingZhang
FumingZhang previously approved these changes Aug 29, 2025
@mainred
Copy link
Member Author

mainred commented Sep 1, 2025

@yanzhudd Please help take a look, thanks.


18.0.0b30
+++++++
* Remove interactive AI-powered debugging tool `az aks agent`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better to add some information about guiding users to download new package to use the related function.

@yanzhudd
Copy link
Contributor

yanzhudd commented Sep 1, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@yanzhudd yanzhudd merged commit 4652d4c into Azure:main Sep 1, 2025
25 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Sep 1, 2025

[Release] Update index.json for extension [ aks-preview-18.0.0b30 ] : https://dev.azure.com/msazure/One/_build/results?buildId=135629444&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants