-
Notifications
You must be signed in to change notification settings - Fork 1.5k
{AKS} remove aks agent from aks-preview #9105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❌Azure CLI Extensions Breaking Change Test
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the AKS agent functionality from the aks-preview extension to address installation performance issues. The agent dependency (holmesgpt) was causing 6+ minute installation times on Windows without detailed logs, negatively impacting users who only needed the aks-preview extension.
- Removes the holmesgpt dependency and all agent-related code
- Updates version from 18.0.0b28 to 18.0.0b29
- Cleans up commands, parameters, validators, and test files related to the agent
Reviewed Changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/aks-preview/setup.py | Removes holmesgpt dependency and bumps version |
| src/aks-preview/azext_aks_preview/tests/latest/test_validators.py | Removes agent config file validation tests |
| src/aks-preview/azext_aks_preview/tests/latest/test_agent.py | Deletes entire agent test file |
| src/aks-preview/azext_aks_preview/custom.py | Removes agent command implementation |
| src/aks-preview/azext_aks_preview/commands.py | Removes agent command registration |
| src/aks-preview/azext_aks_preview/agent/*.py | Deletes all agent implementation files |
| src/aks-preview/azext_aks_preview/_validators.py | Removes agent config file validation functions |
| src/aks-preview/azext_aks_preview/_params.py | Removes agent command parameters |
| src/aks-preview/azext_aks_preview/_help.py | Removes agent command help documentation |
| src/aks-preview/azext_aks_preview/_consts.py | Removes agent-related constants |
| src/aks-preview/HISTORY.rst | Documents removal of the agent functionality |
|
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
|
please resolve merge conflicts |
…into remove-agent-from-aks-preview
|
Just resolved the conflicts and bumped the version. Please help trigger pipeline run again. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@yanzhudd Please help take a look, thanks. |
src/aks-preview/HISTORY.rst
Outdated
|
|
||
| 18.0.0b30 | ||
| +++++++ | ||
| * Remove interactive AI-powered debugging tool `az aks agent`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is better to add some information about guiding users to download new package to use the related function.
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
[Release] Update index.json for extension [ aks-preview-18.0.0b30 ] : https://dev.azure.com/msazure/One/_build/results?buildId=135629444&view=results |
PR description
When installing aks-preview with agent on windows, it takes 6 minutes or more to install holmesgpt without detailed log, this impacts the user who use aks-preview not the agentic tool.
We want to remove this dependency from aks-preview to unblock aks-preview users. Alternatively, we can
We can keep the agent in aks-preview with the last two options. But before we finalize the decision and PR, we use this PR to unblock aks-preview users.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.