Skip to content

Conversation

@calvinhzy
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@calvinhzy calvinhzy self-assigned this Aug 31, 2025
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Aug 31, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 31, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@calvinhzy calvinhzy marked this pull request as ready for review August 31, 2025 13:59
Copilot AI review requested due to automatic review settings August 31, 2025 13:59
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes deprecated DATA_STORAGE references from the aks-preview extension and updates the version number. The changes modernize the storage account SAS token generation by replacing the old CloudStorageAccount approach with the newer generate_account_sas method.

  • Updates extension version from 18.0.0b29 to 18.0.0b30
  • Refactors storage account SAS token generation to use newer Azure SDK methods
  • Removes deprecated _cloud_storage_account_service_factory function

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/aks-preview/setup.py Version bump to 18.0.0b30
src/aks-preview/azext_aks_preview/aks_diagnostics.py Replaces deprecated DATA_STORAGE CloudStorageAccount with DATA_STORAGE_BLOB generate_account_sas
src/aks-preview/HISTORY.rst Adds changelog entry for DATA_STORAGE references removal

@github-actions
Copy link

@FumingZhang
Copy link
Member

please resolve merge conflict

FumingZhang
FumingZhang previously approved these changes Sep 1, 2025
@calvinhzy
Copy link
Member Author

@FumingZhang please help review again.

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@calvinhzy calvinhzy merged commit 20ba43e into Azure:main Sep 1, 2025
25 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Sep 1, 2025

[Release] Update index.json for extension [ aks-preview-18.0.0b31 ] : https://dev.azure.com/msazure/One/_build/results?buildId=135647014&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants