-
Notifications
You must be signed in to change notification settings - Fork 1.5k
{AKS-Preview} Remove DATA_STORAGE references #9110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{AKS-Preview} Remove DATA_STORAGE references #9110
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes deprecated DATA_STORAGE references from the aks-preview extension and updates the version number. The changes modernize the storage account SAS token generation by replacing the old CloudStorageAccount approach with the newer generate_account_sas method.
- Updates extension version from 18.0.0b29 to 18.0.0b30
- Refactors storage account SAS token generation to use newer Azure SDK methods
- Removes deprecated _cloud_storage_account_service_factory function
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/aks-preview/setup.py | Version bump to 18.0.0b30 |
| src/aks-preview/azext_aks_preview/aks_diagnostics.py | Replaces deprecated DATA_STORAGE CloudStorageAccount with DATA_STORAGE_BLOB generate_account_sas |
| src/aks-preview/HISTORY.rst | Adds changelog entry for DATA_STORAGE references removal |
|
|
please resolve merge conflict |
…storage-track1 # Conflicts: # src/aks-preview/HISTORY.rst
|
@FumingZhang please help review again. |
FumingZhang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
[Release] Update index.json for extension [ aks-preview-18.0.0b31 ] : https://dev.azure.com/msazure/One/_build/results?buildId=135647014&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.