Skip to content

Conversation

@dingmeng-xue
Copy link
Member


Fix the issue in #8652. The reference doc is still public available even the service is retiring.

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • [* ] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • [* ] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • [* ] My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings September 1, 2025 09:50
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Sep 1, 2025

⚠️Azure CLI Extensions Breaking Change Test
⚠️spring
rule cmd_name rule_message suggest_message
⚠️ 1014 - SubgroupPropRemove spring sub group spring removed property deprecate_info_hide

@azure-client-tools-bot-prd
Copy link

Hi @dingmeng-xue,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request fixes an issue where the Azure Spring Cloud extension reference documentation was hidden despite still being publicly available. The change removes the hide=True parameter from the deprecation registration to ensure the documentation remains accessible while the service is retiring.

  • Removes the hide=True parameter from the register_command_group_deprecate call for the 'spring' command group
  • Keeps the deprecation notice with target version 'Mar 2028' intact
  • Allows the extension reference documentation to remain visible during the retirement period

@yonzhan
Copy link
Collaborator

yonzhan commented Sep 1, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

github-actions bot commented Sep 1, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link

github-actions bot commented Sep 1, 2025

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link

github-actions bot commented Sep 1, 2025

Hi @dingmeng-xue

⚠️ Release Requirements

Module: spring

  • ⚠️ Please update VERSION to be 1.29.0 in src/spring/setup.py

Notes

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Sep 1, 2025
@yonzhan yonzhan requested a review from yanzhudd September 1, 2025 14:12
@zhoxing-ms zhoxing-ms added skip-cal-version and removed release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. labels Sep 1, 2025
@zhoxing-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@zhoxing-ms zhoxing-ms merged commit b86c1c6 into Azure:main Sep 2, 2025
32 of 37 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Sep 2, 2025

[Release] Update index.json for extension [ spring-1.28.3 ] : https://dev.azure.com/msazure/One/_build/results?buildId=135708908&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants