-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[AKS] az aks add nodepool
support machines pool
#9121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AKS] az aks add nodepool
support machines pool
#9121
Conversation
❌Azure CLI Extensions Breaking Change Test
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for creating machines pool node pools in AKS through the az aks nodepool add
command. The change enables the "Machines" mode as a valid option for the --mode
parameter when adding node pools.
- Adds the "Machines" mode constant and includes it in the allowed values for node pool mode parameters
- Implements a test to verify machines pool creation functionality
- Updates version and changelog to reflect the new feature
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
setup.py | Version bump from 18.0.0b29 to 18.0.0b30 |
test_aks_commands.py | Adds test case for creating machines pool node pools |
test_aks_nodepool_create_machines_pool.yaml | Test recording file for the new machines pool test |
_params.py | Adds CONST_NODEPOOL_MODE_MACHINES to imports and valid mode values |
_consts.py | Defines the new CONST_NODEPOOL_MODE_MACHINES constant |
HISTORY.rst | Documents the new machines agent pool support feature |
src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py
Outdated
Show resolved
Hide resolved
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
failed with error
|
Requeued live test using staging env, test passed! |
[Release] Update index.json for extension [ aks-preview-18.0.0b34 ] : https://dev.azure.com/msazure/One/_build/results?buildId=135967911&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
aks add nodepool to support machines pool
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.