Skip to content

Conversation

zjpjack-github
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

aks add nodepool to support machines pool

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@Copilot Copilot AI review requested due to automatic review settings September 2, 2025 20:26
Copy link

azure-client-tools-bot-prd bot commented Sep 2, 2025

❌Azure CLI Extensions Breaking Change Test
❌aks-preview
rule cmd_name rule_message suggest_message
1010 - ParaPropUpdate aks nodepool add cmd aks nodepool add update parameter spot_max_price: updated property default from nan to nan please change property default from nan to nan for parameter spot_max_price of cmd aks nodepool add
⚠️ 1010 - ParaPropUpdate aks nodepool add cmd aks nodepool add update parameter mode: updated property choices from ['Gateway', 'ManagedSystem', 'System', 'User'] to ['Gateway', 'Machines', 'ManagedSystem', 'System', 'User']
⚠️ 1010 - ParaPropUpdate aks nodepool update cmd aks nodepool update update parameter mode: updated property choices from ['Gateway', 'ManagedSystem', 'System', 'User'] to ['Gateway', 'Machines', 'ManagedSystem', 'System', 'User']

@yonzhan
Copy link
Collaborator

yonzhan commented Sep 2, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

github-actions bot commented Sep 2, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for creating machines pool node pools in AKS through the az aks nodepool add command. The change enables the "Machines" mode as a valid option for the --mode parameter when adding node pools.

  • Adds the "Machines" mode constant and includes it in the allowed values for node pool mode parameters
  • Implements a test to verify machines pool creation functionality
  • Updates version and changelog to reflect the new feature

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
setup.py Version bump from 18.0.0b29 to 18.0.0b30
test_aks_commands.py Adds test case for creating machines pool node pools
test_aks_nodepool_create_machines_pool.yaml Test recording file for the new machines pool test
_params.py Adds CONST_NODEPOOL_MODE_MACHINES to imports and valid mode values
_consts.py Defines the new CONST_NODEPOOL_MODE_MACHINES constant
HISTORY.rst Documents the new machines agent pool support feature

Copy link

github-actions bot commented Sep 2, 2025

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Sep 2, 2025
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Sep 2, 2025
Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Queued live test to validate the change.

  • test_aks_nodepool_create_machines_pool

@FumingZhang
Copy link
Member

lgtm

Queued live test to validate the change.

  • test_aks_nodepool_create_machines_pool

failed with error

>           raise HttpResponseError(response=self._pipeline_response.http_response, error=err) from err
E           azure.core.exceptions.HttpResponseError: (InvalidResourceType) The resource type 'locations' could not be found in the namespace 'Microsoft.ContainerService' for api version '2025-03-01'. The supported api-versions are '2015-11-01-preview,2016-03-30,2016-09-30,2017-01-31,2017-08-31'.
E           Code: InvalidResourceType
E           Message: The resource type 'locations' could not be found in the namespace 'Microsoft.ContainerService' for api version '2025-03-01'. The supported api-versions are '2015-11-01-preview,2016-03-30,2016-09-30,2017-01-31,2017-08-31'.

@FumingZhang
Copy link
Member

FumingZhang commented Sep 4, 2025

lgtm
Queued live test to validate the change.

  • test_aks_nodepool_create_machines_pool

failed with error

>           raise HttpResponseError(response=self._pipeline_response.http_response, error=err) from err
E           azure.core.exceptions.HttpResponseError: (InvalidResourceType) The resource type 'locations' could not be found in the namespace 'Microsoft.ContainerService' for api version '2025-03-01'. The supported api-versions are '2015-11-01-preview,2016-03-30,2016-09-30,2017-01-31,2017-08-31'.
E           Code: InvalidResourceType
E           Message: The resource type 'locations' could not be found in the namespace 'Microsoft.ContainerService' for api version '2025-03-01'. The supported api-versions are '2015-11-01-preview,2016-03-30,2016-09-30,2017-01-31,2017-08-31'.

Requeued live test using staging env, test passed!

@zhoxing-ms zhoxing-ms merged commit 1d48b87 into Azure:main Sep 4, 2025
25 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Sep 4, 2025

[Release] Update index.json for extension [ aks-preview-18.0.0b34 ] : https://dev.azure.com/msazure/One/_build/results?buildId=135967911&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants