Skip to content

Conversation

@justin-mccann
Copy link


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings September 12, 2025 18:10
@azure-client-tools-bot-prd
Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

@azure-client-tools-bot-prd
Copy link

Hi @justin-mccann,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses variable initialization issues in the enable_features() function by unconditionally defining final_enable_cl and custom_locations_oid variables before their potential use in conditional blocks.

  • Initializes final_enable_cl to False and custom_locations_oid to None before the enable_cl conditional block

@yonzhan
Copy link
Collaborator

yonzhan commented Sep 12, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link

Hi @justin-mccann

Release Suggestions

Module: connectedk8s

  • Please log updates into to src/connectedk8s/HISTORY.rst
  • Update VERSION to 1.10.9 in src/connectedk8s/setup.py

Notes

@justin-mccann
Copy link
Author

The failing azdev-style checks are unrelated to this PR.

@justin-mccann
Copy link
Author

@yonzhan Any update here?

@justin-mccann
Copy link
Author

This appears to be fixed in #9254

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants