-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Unconditionally define custom-locations variables in enable_features() #9160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unconditionally define custom-locations variables in enable_features() #9160
Conversation
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Hi @justin-mccann, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses variable initialization issues in the enable_features() function by unconditionally defining final_enable_cl and custom_locations_oid variables before their potential use in conditional blocks.
- Initializes
final_enable_cltoFalseandcustom_locations_oidtoNonebefore theenable_clconditional block
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Release SuggestionsModule: connectedk8s
Notes
|
|
The failing |
|
@yonzhan Any update here? |
|
This appears to be fixed in #9254 |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.