Skip to content

Comments

{AuthV2} az webapp auth update: Fix --excluded-paths logic#9310

Closed
a0x1ab wants to merge 3 commits intoAzure:mainfrom
a0x1ab:main
Closed

{AuthV2} az webapp auth update: Fix --excluded-paths logic#9310
a0x1ab wants to merge 3 commits intoAzure:mainfrom
a0x1ab:main

Conversation

@a0x1ab
Copy link
Member

@a0x1ab a0x1ab commented Oct 17, 2025

Related command

az webapp auth update -g {resource-group} --excluded-paths {paths}

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@a0x1ab a0x1ab self-assigned this Oct 17, 2025
Copilot AI review requested due to automatic review settings October 17, 2025 09:32
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Oct 17, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @a0x1ab,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 17, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Contributor

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the logic for parsing the --excluded-paths parameter in the az webapp auth update command. The fix improves handling of different input formats including JSON arrays, comma-separated strings, and single paths.

  • Replaces the problematic string slicing logic with proper JSON parsing and fallback to comma-separated parsing
  • Adds comprehensive test coverage for various excluded paths input formats
  • Ensures the command correctly handles JSON arrays, comma-separated values, and paths with special characters

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/authV2/azext_authV2/custom.py Updates excluded paths parsing logic with proper JSON handling and fallback mechanisms
src/authV2/azext_authV2/tests/latest/test_authV2_scenario.py Adds comprehensive test cases for different excluded paths input formats

@github-actions
Copy link
Contributor

Hi @a0x1ab

Release Suggestions

Module: authV2

  • Please log updates into to src/authV2/HISTORY.rst
  • Update VERSION to 1.0.1 in src/authV2/setup.py

Notes

@a0x1ab a0x1ab closed this Oct 17, 2025
@a0x1ab
Copy link
Member Author

a0x1ab commented Oct 17, 2025

Reopened from the correct feature branch here: #9311

@a0x1ab a0x1ab removed this from the November 2025 (2025-11-04) milestone Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants