{AuthV2} az webapp auth update: Fix --excluded-paths logic#9310
{AuthV2} az webapp auth update: Fix --excluded-paths logic#9310a0x1ab wants to merge 3 commits intoAzure:mainfrom
az webapp auth update: Fix --excluded-paths logic#9310Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @a0x1ab, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the logic for parsing the --excluded-paths parameter in the az webapp auth update command. The fix improves handling of different input formats including JSON arrays, comma-separated strings, and single paths.
- Replaces the problematic string slicing logic with proper JSON parsing and fallback to comma-separated parsing
- Adds comprehensive test coverage for various excluded paths input formats
- Ensures the command correctly handles JSON arrays, comma-separated values, and paths with special characters
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/authV2/azext_authV2/custom.py | Updates excluded paths parsing logic with proper JSON handling and fallback mechanisms |
| src/authV2/azext_authV2/tests/latest/test_authV2_scenario.py | Adds comprehensive test cases for different excluded paths input formats |
|
Hi @a0x1ab Release SuggestionsModule: authV2
Notes
|
|
Reopened from the correct feature branch here: #9311 |
Related command
az webapp auth update -g {resource-group} --excluded-paths {paths}General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.