-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Application Gateway for Containers addon commands #9387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks applicationloadbalancer | sub group aks applicationloadbalancer added |
||
| aks create | cmd aks create added parameter enable_application_load_balancer |
|
Hi @JackStromberg, |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
Release SuggestionsModule: aks-preview
Notes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for the Application Load Balancer (Application Gateway for Containers) addon to AKS clusters. The implementation follows the pattern established for other special addons like web app routing.
Key changes:
- Adds new CLI commands
az aks applicationloadbalancer enable/disable/updatefor managing the addon - Integrates the addon into existing addon management infrastructure (
aks addon enable/disable) - Stores configuration in the cluster's ingress profile rather than the standard addon profile
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| managed_cluster_decorator.py | Adds getter method for the parameter and methods to set up and update the application load balancer profile in the ingress profile |
| custom.py | Implements the enable/disable/update commands and integrates with existing addon list/show/enable/disable functionality |
| commands.py | Registers the new aks applicationloadbalancer command group with enable, disable, and update commands |
| addonconfiguration.py | Adds handling for the applicationloadbalancer addon in the update_addons function |
| _help.py | Adds documentation for the new commands and updates addon descriptions; fixes typo in app routing help |
| _consts.py | Defines constants for the new addon name and adds it to the ADDONS dictionary and descriptions |
| HISTORY.rst | Documents the new feature in the pending release notes |
Co-authored-by: Copilot <[email protected]>
FumingZhang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add a new scenario test case (may refer to existing examples from test_aks_commands.py) for the change?
| name_prefix="clitest", | ||
| location="westus2", | ||
| ) | ||
| def test_aks_applicationloadbalancer_enable_disable( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Queued live test against staging-westus2.
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
CI failed with error
E azure.core.exceptions.HttpResponseError: (PreviewFeatureNotRegistered) Preview feature Microsoft.ContainerService/ApplicationLoadBalancerPreview not registered. Does the feature flag verification allow bypassing with a custom features header? If it does, you can include the relevant header in your test case and rerun the live test to create a new recording file. |
@FumingZhang no, registration of the feature is required. |
|
Okay, in that case, you can remove the case from the default test matrix at src/aks-preview/azcli_aks_live_test/configs/ext_matrix_default.json and run it in live mode in a subscription where the feature is registered. This will allow you to generate a recording file that should pass the CI check. |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks applicationloadbalancer enable: Enable Application Load Balancer add-on for an existing cluster.az aks applicationloadbalancer disable: Disable Application Load Balancer add-on for an existing cluster.az aks applicationloadbalancer update: Update Application Load Balancer add-on for an existing cluster.General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)