Skip to content

Conversation

@gabemousa
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Bavneet Singh and others added 14 commits September 30, 2025 09:40
* forcedelete

* format

* add code owner

* mypy
…add E2E coverage and improve logging (#20)

* add pester tests for connectedk8s cli extension

* Pass the force delete param to the API call (#4)

* forcedelete

* format

* add code owner

* mypy

* Parameterize for airgapped clouds (#5)

* Add parameterization for the airgapped clouds

* Fix azdev style

* MCR path function

* azdev, ruff, and mypy

---------

Co-authored-by: Matthew McNeal (from Dev Box) <[email protected]>

* Oras client fix to work with different MCRs (#6)

Co-authored-by: mmcneal <[email protected]>

* fix CI testcases for nodepool image issues (#8)

* update errors for the config and connectivity issues (#11)

* update errors

* format

* style

* update python version to 3.13 (#12)

* Update cluster diagnostics image to 1.29.3 (#7)

* Update cluster diagnostics helm chart to 1.29.3

* Fix lint issues

---------

Co-authored-by: bgriddaluru <[email protected]>

* RBAC deprecation & fix the issue

* typo

* fix comments

* update tests

* add pester tests for connectedk8s cli extension

* Pass the force delete param to the API call (#4)

* forcedelete

* format

* add code owner

* mypy

* fix CI testcases for nodepool image issues (#8)

* update errors for the config and connectivity issues (#11)

* update errors

* format

* style

* update python version to 3.13 (#12)

* rebase

* fix tests

* fix version

* fix mypy, lint

* fix test

* fix test

* fix test

* fix test

* fix test

* rename test

* deprecate flags

* rebase

* rebase

* bump version for release

---------

Co-authored-by: Bavneet Singh <[email protected]>
Co-authored-by: Atchut Kumar Barli <[email protected]>
Co-authored-by: mcnealm13 <[email protected]>
Co-authored-by: Matthew McNeal (from Dev Box) <[email protected]>
Co-authored-by: Bavneet Singh <[email protected]>
Co-authored-by: bgriddaluru <[email protected]>
Co-authored-by: bgriddaluru <[email protected]>
Co-authored-by: vithumma <[email protected]>
* add agc overrides

* update gns endpoint

* add indentation

* fix linter error

* fix ruff formatting

* move overrides to it's own method

* update method

* update ruff formatting
* add pester tests for connectedk8s cli extension

* Pass the force delete param to the API call (#4)

* forcedelete

* format

* add code owner

* mypy

* Parameterize for airgapped clouds (#5)

* Add parameterization for the airgapped clouds

* Fix azdev style

* MCR path function

* azdev, ruff, and mypy

---------

Co-authored-by: Matthew McNeal (from Dev Box) <[email protected]>

* Oras client fix to work with different MCRs (#6)

Co-authored-by: mmcneal <[email protected]>

* fix CI testcases for nodepool image issues (#8)

* update errors for the config and connectivity issues (#11)

* update errors

* format

* style

* update python version to 3.13 (#12)

* Update cluster diagnostics image to 1.29.3 (#7)

* Update cluster diagnostics helm chart to 1.29.3

* Fix lint issues

---------

Co-authored-by: bgriddaluru <[email protected]>

* RBAC deprecation & fix the issue

* typo

* fix comments

* update tests

* add pester tests for connectedk8s cli extension

* Pass the force delete param to the API call (#4)

* forcedelete

* format

* add code owner

* mypy

* fix CI testcases for nodepool image issues (#8)

* update errors for the config and connectivity issues (#11)

* update errors

* format

* style

* update python version to 3.13 (#12)

* rebase

* fix tests

* fix version

* fix mypy, lint

* fix test

* fix test

* fix test

* fix test

* fix test

* rename test

* add pester tests for connectedk8s cli extension

* Pass the force delete param to the API call (#4)

* forcedelete

* format

* add code owner

* mypy

* fix CI testcases for nodepool image issues (#8)

* update python version to 3.13 (#12)

* changes to support gateway association/disassociation for api version '2025-08-01-preview' (#17)

* [Azure RBAC] Deprecate 3P mode flags, fix Azure RBAC enablement bug, add E2E coverage and improve logging (#20)

* add pester tests for connectedk8s cli extension

* Pass the force delete param to the API call (#4)

* forcedelete

* format

* add code owner

* mypy

* Parameterize for airgapped clouds (#5)

* Add parameterization for the airgapped clouds

* Fix azdev style

* MCR path function

* azdev, ruff, and mypy

---------

Co-authored-by: Matthew McNeal (from Dev Box) <[email protected]>

* Oras client fix to work with different MCRs (#6)

Co-authored-by: mmcneal <[email protected]>

* fix CI testcases for nodepool image issues (#8)

* update errors for the config and connectivity issues (#11)

* update errors

* format

* style

* update python version to 3.13 (#12)

* Update cluster diagnostics image to 1.29.3 (#7)

* Update cluster diagnostics helm chart to 1.29.3

* Fix lint issues

---------

Co-authored-by: bgriddaluru <[email protected]>

* RBAC deprecation & fix the issue

* typo

* fix comments

* update tests

* add pester tests for connectedk8s cli extension

* Pass the force delete param to the API call (#4)

* forcedelete

* format

* add code owner

* mypy

* fix CI testcases for nodepool image issues (#8)

* update errors for the config and connectivity issues (#11)

* update errors

* format

* style

* update python version to 3.13 (#12)

* rebase

* fix tests

* fix version

* fix mypy, lint

* fix test

* fix test

* fix test

* fix test

* fix test

* rename test

* deprecate flags

* rebase

* rebase

* bump version for release

---------

Co-authored-by: Bavneet Singh <[email protected]>
Co-authored-by: Atchut Kumar Barli <[email protected]>
Co-authored-by: mcnealm13 <[email protected]>
Co-authored-by: Matthew McNeal (from Dev Box) <[email protected]>
Co-authored-by: Bavneet Singh <[email protected]>
Co-authored-by: bgriddaluru <[email protected]>
Co-authored-by: bgriddaluru <[email protected]>
Co-authored-by: vithumma <[email protected]>

* remove breaking change announcement for removed flags

---------

Co-authored-by: Bavneet Singh <[email protected]>
Co-authored-by: Atchut Kumar Barli <[email protected]>
Co-authored-by: mcnealm13 <[email protected]>
Co-authored-by: Matthew McNeal (from Dev Box) <[email protected]>
Co-authored-by: Bavneet Singh <[email protected]>
Co-authored-by: bgriddaluru <[email protected]>
Co-authored-by: bgriddaluru <[email protected]>
Co-authored-by: vithumma <[email protected]>
Copilot AI review requested due to automatic review settings November 5, 2025 18:49
@azure-client-tools-bot-prd
Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

@azure-client-tools-bot-prd
Copy link

Hi @gabemousa,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@github-actions
Copy link

github-actions bot commented Nov 5, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 5, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

github-actions bot commented Nov 5, 2025

Hi @gabemousa

⚠️ Release Requirements

Module: connectedk8s

  • ⚠️ Please update VERSION to be 2.0.0 in src/connectedk8s/setup.py

Module: k8s-extension

  • Please log updates into to src/k8s-extension/HISTORY.rst
  • Update VERSION to 1.7.1 in src/k8s-extension/setup.py

Notes

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a comprehensive testing framework for the connectedk8s Azure CLI extension, including test suites for various scenarios (WorkloadIdentity, Gateway, Proxy, etc.), along with supporting infrastructure and a version bump for the CLIENT_PROXY_VERSION constant.

Key Changes:

  • Added test infrastructure with Pester-based PowerShell test suites for multiple scenarios
  • Added helper scripts for bootstrapping, testing, and configuration
  • Updated CLIENT_PROXY_VERSION from "1.3.029301" to "1.3.032281"

Reviewed Changes

Copilot reviewed 19 out of 23 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
testing/test/helper/Constants.ps1 Defines test configuration constants
testing/test/configurations/*.Tests.ps1 Test suites for various scenarios (WorkloadIdentity, Troubleshoot, Proxy, Gateway, ForcedDelete, EnableDisableFeatures, ConnectProxy, BasicOnboarding, AutoUpdate)
testing/Test.ps1 Main test execution script
testing/Bootstrap.ps1 Environment setup script
testing/settings.template.json Configuration template
testing/pipeline/*.yml CI/CD pipeline definitions
src/connectedk8s/azext_connectedk8s/_constants.py Version constant update

if ($isProxyEnabled -match "isProxyEnabled: false") {
break
}
break
Copy link

Copilot AI Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate break statement at line 49 causes unreachable code. The second break statement will execute unconditionally when $provisioningState equals $SUCCEEDED, regardless of the proxy status check result. This means the test will pass even if the proxy wasn't actually disabled. Remove the redundant break at line 49.

Suggested change
break

Copilot uses AI. Check for mistakes.
BeforeAll {
. $PSScriptRoot/../helper/Constants.ps1

$SelfHostedIssuer = "https://eastus.oic.prod-aks.azure.com/fc50e82b-3761-4218-8691-d98bcgb146da/e6c4bf03-84d9-480c-a269-37a41c28c5cb/"
Copy link

Copilot AI Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in the URL path segment 'd98bcgb146da' appears to contain 'bcgb' which should likely be 'bcfb' based on typical GUID patterns.

Suggested change
$SelfHostedIssuer = "https://eastus.oic.prod-aks.azure.com/fc50e82b-3761-4218-8691-d98bcgb146da/e6c4bf03-84d9-480c-a269-37a41c28c5cb/"
$SelfHostedIssuer = "https://eastus.oic.prod-aks.azure.com/fc50e82b-3761-4218-8691-d98bcfb146da/e6c4bf03-84d9-480c-a269-37a41c28c5cb/"

Copilot uses AI. Check for mistakes.
@github-actions
Copy link

github-actions bot commented Nov 5, 2025

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Nov 5, 2025
@gabemousa gabemousa closed this Nov 5, 2025
@gabemousa gabemousa deleted the gabrielmousa/proxyupdate branch November 5, 2025 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants