Skip to content

Conversation

@khushishah513
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings November 17, 2025 07:04
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Nov 17, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @khushishah513,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 17, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copilot finished reviewing on behalf of khushishah513 November 17, 2025 07:06
@khushishah513
Copy link
Contributor Author

image

The added check ensures that there will be an error if the min-replica is set to 0 and container has scaled down to 0 replicas. The error also provides with the command to update mi-replica to 1.

@github-actions
Copy link

Hi @khushishah513

Release Suggestions

Module: containerapp

  • Please log updates into to src/containerapp/HISTORY.rst
  • Update VERSION to 1.3.0b2 in src/containerapp/setup.py

Notes

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the get_random_replica function in the containerapp extension to provide a more informative error message when no replicas are found for a revision that has minReplicas set to 0. This improves the user experience for function key management commands by guiding users to fix the underlying issue.

  • Added logic to check if a revision has minReplicas set to 0 when no replicas are found
  • Provides a specific error message with remediation steps when the issue is due to minReplicas being 0
  • Falls back to the generic "No replicas found" error for other scenarios

@khushishah513 khushishah513 changed the title [Containerapp] updating min-replica check for keys management in az containerapp function keys commands [Containerapp] updating min-replica check for az containerapp function keys/invocations commands Nov 17, 2025
@khushishah513 khushishah513 changed the title [Containerapp] updating min-replica check for az containerapp function keys/invocations commands [Containerapp] updating min-replica check for az containerapp function keys commands and modifications to app-insights query for az containerapp function invocations Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot ContainerApp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants