-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[Containerapp] updating min-replica check for az containerapp function keys commands and modifications to app-insights query for az containerapp function invocations
#9431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @khushishah513, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
Release SuggestionsModule: containerapp
Notes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the get_random_replica function in the containerapp extension to provide a more informative error message when no replicas are found for a revision that has minReplicas set to 0. This improves the user experience for function key management commands by guiding users to fix the underlying issue.
- Added logic to check if a revision has
minReplicasset to 0 when no replicas are found - Provides a specific error message with remediation steps when the issue is due to
minReplicasbeing 0 - Falls back to the generic "No replicas found" error for other scenarios
az containerapp function keys commands az containerapp function keys/invocations commands
az containerapp function keys/invocations commands az containerapp function keys commands and modifications to app-insights query for az containerapp function invocations

This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.