[Hotfix][dataprotection] Fix regression to AKS restore initialization caused by PR #9834.#9448
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @zubairabid, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
There was a problem hiding this comment.
Pull request overview
This hotfix addresses a critical regression introduced in PR #9834 that prevented AKS customers from initializing restore objects due to incorrect control flow branching.
Key Changes:
- Added early return for AKS restore criteria processing to prevent execution of blob-specific logic
- Fixed indentation of blob-specific processing logic to properly scope it within the
elseblock
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
|
Please fix CI issues |
@yonzhan I've fixed these |
|
[Release] Update index.json for extension [ dataprotection-1.7.1 ] : https://dev.azure.com/msazure/One/_build/results?buildId=145171133&view=results |
PR #9834 introduced a bug where AKS customers trying to initialize a restore object would be unable to due to faulty if-condition branching. Fix for that.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.