[confcom] Add containers from_image command #9478
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Why Addresses - Azure#9222 ### How - [x] Update the code to restore the "attach to first image in input" behaviour - [x] Add two new commands: `fragment push` and `fragment attach` to allow the user to explicitly do one or the other (or both!) - [x] Add new tests which run a local docker registry, and test that the fragments are generated, signed, pushed and attached as expected (as well as the default behaviour) --- This checklist is used to make sure that common guidelines for a pull request are followed. ### Related command <!--- Please provide the related command with az {command} if you can, so that we can quickly route to the related person to review. ---> ### General Guidelines - [x] Have you run `azdev style <YOUR_EXT>` locally? (`pip install azdev` required) - [x] Have you run `python scripts/ci/test_index.py -q` locally? (`pip install wheel==0.30.0` required) - [x] My extension version conforms to the [Extension version schema](https://github.com/Azure/azure-cli/blob/release/doc/extensions/versioning_guidelines.md)
This reverts commit e8f7637.
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| confcom | sub group confcom updated property sub_groups from {} to {'confcom fragment': {'name': 'confcom fragment', 'commands': {'confcom fragment attach': {'name': 'confcom fragment attach', 'is_aaz': False, 'is_preview': True, 'parameters': [{'name': 'signed_fragment', 'options': [], 'type': 'custom_type', 'required': True, 'nargs': '?', 'default': "<_io.BufferedReader name='<stdin>'>"}, {'name': 'manifest_tag', 'options': ['--manifest-tag'], 'required': True}]}, 'confcom fragment push': {'name': 'confcom fragment push', 'is_aaz': False, 'is_preview': True, 'parameters': [{'name': 'signed_fragment', 'options': [], 'type': 'custom_type', 'required': True, 'nargs': '?', 'default': "<_io.BufferedReader name='<stdin>'>"}, {'name': 'manifest_tag', 'options': ['--manifest-tag'], 'required': True}]}}, 'sub_groups': {}}, 'confcom containers': {'name': 'confcom containers', 'commands': {'confcom containers from_image': {'name': 'confcom containers from_image', 'is_aaz': False, 'parameters': [{'name': 'image', 'options': [], 'type': 'string', 'required': True}, {'name': 'platform', 'options': ['--platform'], 'type': 'string', 'default': 'aci'}]}}, 'sub_groups': {}}} |
||
| confcom acifragmentgen | cmd confcom acifragmentgen added parameter out_signed_fragment |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
5 tasks
|
Hi @DomAyre Release SuggestionsModule: confcom
Notes
|
Addresses - Azure#9222 - [x] Update the code to restore the "attach to first image in input" behaviour - [x] Add two new commands: `fragment push` and `fragment attach` to allow the user to explicitly do one or the other (or both!) - [x] Add new tests which run a local docker registry, and test that the fragments are generated, signed, pushed and attached as expected (as well as the default behaviour) --- This checklist is used to make sure that common guidelines for a pull request are followed. <!--- Please provide the related command with az {command} if you can, so that we can quickly route to the related person to review. ---> - [x] Have you run `azdev style <YOUR_EXT>` locally? (`pip install azdev` required) - [x] Have you run `python scripts/ci/test_index.py -q` locally? (`pip install wheel==0.30.0` required) - [x] My extension version conforms to the [Extension version schema](https://github.com/Azure/azure-cli/blob/release/doc/extensions/versioning_guidelines.md)
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exists solely to provide testing for DomAyre#10