NginxExtension - update docs to show standardv3 plans in examples by briantkim93 · Pull Request #9534 · Azure/azure-cli-extensions

briantkim93 · 2026-01-19T16:42:36Z

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
My extension version conforms to the Extension version schema

For new extensions:

My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

azure-client-tools-bot-prd · 2026-01-19T16:42:39Z

️✔️Azure CLI Extensions Breaking Change Test

️✔️Non Breaking Changes

yonzhan · 2026-01-19T16:42:45Z

Thank you for your contribution! We will review the pull request and get back to you soon.

github-actions · 2026-01-19T16:42:49Z

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

github-actions · 2026-01-19T16:43:45Z

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

github-actions · 2026-01-19T16:46:09Z

For more info about extension versioning, please refer to Extension version schema

Copilot

Pull request overview

This PR claims to update NGINX extension documentation to show the new "standardv3" marketplace SKU in examples. However, the actual code changes do not align with this stated purpose.

Changes:

Version bump from 2.0.0b9 to 2.0.0b10
Removal of --enable-diagnostics true flag from a test command
Update of API key expiration date in test from November 2025 to February 2026

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File	Description
src/nginx/setup.py	Version incremented to 2.0.0b10
src/nginx/HISTORY.rst	Added release notes claiming SKU documentation updates
src/nginx/azext_nginx/tests/latest/test_nginx_scenario.py	Removed diagnostics flag and updated test API key expiration date

Copilot · 2026-01-19T16:52:35Z

src/nginx/HISTORY.rst


+2.0.0b10
++++++
+* Updated Nginx Deployment documentation to show new marketplace SKU in examples.


The release notes claim to have "Updated Nginx Deployment documentation to show new marketplace SKU in examples," but the actual changes in this PR are:

Removal of the --enable-diagnostics true flag from a test command

Update of an API key expiration date in a test

No documentation files containing SKU examples (such as files in the aaz directory) have been updated, and there are no references to "standardv3" anywhere in the codebase. The release notes should accurately describe the actual changes made in this PR.

Suggested change

* Updated Nginx Deployment documentation to show new marketplace SKU in examples.

* Removed the ``--enable-diagnostics true`` flag from a test command.

* Updated the API key expiration date in a test.

Copilot · 2026-01-19T16:52:35Z

src/nginx/azext_nginx/tests/latest/test_nginx_scenario.py

        })
        self.kwargs['identities'] = "{\"type\":\"UserAssigned\",\"userAssignedIdentities\":{\"" + managed_identity['id'] + "\":{}}}"
-        self.cmd('nginx deployment create --name {deployment_name} --resource-group {rg} --location {location} --sku name={sku} --enable-diagnostics true --network-profile front-end-ip-configuration="{public_ip_addresses}" network-interface-configuration="{subnet_id}" --identity {identities} --scaling-properties capacity=10 --auto-upgrade-profile upgrade-channel=preview', checks=[
+        self.cmd('nginx deployment create --name {deployment_name} --resource-group {rg} --location {location} --sku name={sku} --network-profile front-end-ip-configuration="{public_ip_addresses}" network-interface-configuration="{subnet_id}" --identity {identities} --scaling-properties capacity=10 --auto-upgrade-profile upgrade-channel=preview', checks=[


The removal of the --enable-diagnostics true flag from this test command appears to be intentional but is not documented in the HISTORY.rst file. This change should either be explained in the release notes or reverted if it was unintentional.

Suggested change

self.cmd('nginx deployment create --name {deployment_name} --resource-group {rg} --location {location} --sku name={sku} --network-profile front-end-ip-configuration="{public_ip_addresses}" network-interface-configuration="{subnet_id}" --identity {identities} --scaling-properties capacity=10 --auto-upgrade-profile upgrade-channel=preview', checks=[

self.cmd('nginx deployment create --name {deployment_name} --resource-group {rg} --location {location} --sku name={sku} --network-profile front-end-ip-configuration="{public_ip_addresses}" network-interface-configuration="{subnet_id}" --identity {identities} --scaling-properties capacity=10 --auto-upgrade-profile upgrade-channel=preview --enable-diagnostics true', checks=[

necusjz · 2026-01-20T02:29:57Z

/azp run

azure-pipelines · 2026-01-20T02:30:10Z

Azure Pipelines successfully started running 2 pipeline(s).

necusjz · 2026-01-22T02:02:11Z

/azp run

azure-pipelines · 2026-01-22T02:02:24Z

Azure Pipelines successfully started running 2 pipeline(s).

necusjz · 2026-01-22T23:12:34Z

/azp run

azure-pipelines · 2026-01-22T23:12:49Z

Azure Pipelines successfully started running 2 pipeline(s).

necusjz · 2026-01-23T02:56:20Z

src/nginx/azext_nginx/aaz/latest/nginx/deployment/configuration/_update.py

            options=["--root-file"],
            arg_group="Properties",
-            help="The root file of the Nginx Configuration",
+             help="The root file of the Nginx Configuration",


a wrong indentation?

necusjz · 2026-01-23T02:57:38Z

src/nginx/azext_nginx/aaz/latest/nginx/deployment/_create.py


    :example: Deployment Create with PublicIP
-        az nginx deployment create --name myDeployment --resource-group myResourceGroup --location eastus2 --sku name="standard_Monthly_gmz7xq9ge3py" --network-profile front-end-ip-configuration="{public-ip-addresses:[{id:/subscriptions/mySubscription/resourceGroups/myResourceGroup/providers/Microsoft.Network/publicIPAddresses/myPublicIP}]}" network-interface-configuration="{subnet-id:/subscriptions/mySubscription/resourceGroups/myResourceGroup/providers/Microsoft.Network/virtualNetworks/myVNet/subnets/mySubnet}"
+        az nginx deployment create --name myDeployment --resource-group myResourceGroup --location eastus2 --sku name="standardv3_Monthly_gmz7xq9ge3py" --network-profile front-end-ip-configuration="{public-ip-addresses:[{id:/subscriptions/mySubscription/resourceGroups/myResourceGroup/providers/Microsoft.Network/publicIPAddresses/myPublicIP}]}" network-interface-configuration="{subnet-id:/subscriptions/mySubscription/resourceGroups/myResourceGroup/providers/Microsoft.Network/virtualNetworks/myVNet/subnets/mySubnet}"


as the generated codes been modified, better to provide the link of pr in Azure/aaz.

Here's the link - Azure/aaz#930

necusjz · 2026-01-25T13:36:13Z

/azp run

azure-pipelines · 2026-01-25T13:36:26Z

Azure Pipelines successfully started running 2 pipeline(s).

necusjz · 2026-01-27T00:17:25Z

/azp run

azure-pipelines · 2026-01-27T00:17:38Z

Azure Pipelines successfully started running 2 pipeline(s).

azclibot · 2026-01-27T03:49:22Z

[Release] Update index.json for extension [ nginx-2.0.0b10 ] : https://dev.azure.com/msazure/One/_build/results?buildId=150736894&view=results

briantkim-msft added 2 commits January 19, 2026 19:38

Update docs to show standardv3 marketplace plans in examples

ddac7e2

Updated history and setup files

5ea9971

Copilot AI review requested due to automatic review settings January 19, 2026 16:42

azure-client-tools-bot-prd bot added this to the February 2026 (2026-02-03) milestone Jan 19, 2026

Copilot started reviewing on behalf of briantkim93 January 19, 2026 16:43 View session

briantkim93 marked this pull request as draft January 19, 2026 16:45

Copilot AI reviewed Jan 19, 2026

View reviewed changes

yonzhan requested review from jsntcy, kairu-ms and necusjz January 20, 2026 00:30

yonzhan assigned kairu-ms Jan 20, 2026

briantkim-msft added 3 commits January 21, 2026 21:18

Added test recording

7e4fd3a

Added standardv3 in examples

0ecead6

Added standardv3 in examples

99cabe3

briantkim93 marked this pull request as ready for review January 21, 2026 18:40

Updated azure-cli and reran tests

5b9d072

necusjz reviewed Jan 23, 2026

View reviewed changes

Corrected indentation

de39c42

Reran tests

3a501e5

Reran tests

601f105

necusjz approved these changes Jan 27, 2026

View reviewed changes

necusjz merged commit ace6fca into Azure:main Jan 27, 2026
24 checks passed

	* Updated Nginx Deployment documentation to show new marketplace SKU in examples.
	* Removed the ``--enable-diagnostics true`` flag from a test command.
	* Updated the API key expiration date in a test.

	self.cmd('nginx deployment create --name {deployment_name} --resource-group {rg} --location {location} --sku name={sku} --network-profile front-end-ip-configuration="{public_ip_addresses}" network-interface-configuration="{subnet_id}" --identity {identities} --scaling-properties capacity=10 --auto-upgrade-profile upgrade-channel=preview', checks=[
	self.cmd('nginx deployment create --name {deployment_name} --resource-group {rg} --location {location} --sku name={sku} --network-profile front-end-ip-configuration="{public_ip_addresses}" network-interface-configuration="{subnet_id}" --identity {identities} --scaling-properties capacity=10 --auto-upgrade-profile upgrade-channel=preview --enable-diagnostics true', checks=[

Conversation

briantkim93 commented Jan 19, 2026

Related command

General Guidelines

About Extension Publish

Uh oh!

azure-client-tools-bot-prd bot commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yonzhan commented Jan 19, 2026

Uh oh!

github-actions bot commented Jan 19, 2026

Uh oh!

github-actions bot commented Jan 19, 2026

CodeGen Tools Feedback Collection

Uh oh!

github-actions bot commented Jan 19, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

necusjz commented Jan 20, 2026

Uh oh!

azure-pipelines bot commented Jan 20, 2026

Uh oh!

necusjz commented Jan 22, 2026

Uh oh!

azure-pipelines bot commented Jan 22, 2026

Uh oh!

necusjz commented Jan 22, 2026

Uh oh!

azure-pipelines bot commented Jan 22, 2026

Uh oh!

necusjz Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

necusjz Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

briantkim93 Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

necusjz commented Jan 25, 2026

Uh oh!

azure-pipelines bot commented Jan 25, 2026

Uh oh!

necusjz commented Jan 27, 2026

Uh oh!

azure-pipelines bot commented Jan 27, 2026

Uh oh!

Uh oh!

azclibot commented Jan 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

azure-client-tools-bot-prd bot commented Jan 19, 2026 •

edited

Loading