Adding extension managedcleanroom#9563
Conversation
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Hi @kkarmakarMS, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
There was a problem hiding this comment.
Pull request overview
Adds a new Azure CLI extension az managedcleanroom for the Microsoft.CleanRoom resource provider.
Changes:
- Registers the new
az managedcleanroomcommand group in the repo’s service mapping index. - Introduces the
managedcleanroomextension package scaffolding, metadata, and generated AAZ command surface for consortium / consortium-view / collaboration operations. - Adds an initial unit test for provider-namespace selection logic.
Reviewed changes
Copilot reviewed 57 out of 57 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/service_name.json | Adds service mapping entry for az managedcleanroom to align command group with docs/service name. |
| src/managedcleanroom/setup.py | Adds Python packaging for the new extension (version, metadata, package discovery). |
| src/managedcleanroom/setup.cfg | Adds extension setup configuration placeholder. |
| src/managedcleanroom/README.md | Adds extension README with install instructions and a sample command. |
| src/managedcleanroom/HISTORY.rst | Adds initial changelog entry for 1.0.0b1. |
| src/managedcleanroom/azext_managedcleanroom/init.py | Adds command loader wiring for AAZ-based command table and arguments loading. |
| src/managedcleanroom/azext_managedcleanroom/_help.py | Adds help module import hook for extension help entries. |
| src/managedcleanroom/azext_managedcleanroom/_params.py | Adds placeholder argument loader (AAZ commands define most args). |
| src/managedcleanroom/azext_managedcleanroom/commands.py | Adds placeholder command table loader (AAZ decorators register commands). |
| src/managedcleanroom/azext_managedcleanroom/custom.py | Adds placeholder for custom-command implementations and logger setup. |
| src/managedcleanroom/azext_managedcleanroom/azext_metadata.json | Declares preview status and minimum Azure CLI core version. |
| src/managedcleanroom/azext_managedcleanroom/aaz/init.py | Adds AAZ package marker for the extension. |
| src/managedcleanroom/azext_managedcleanroom/aaz/latest/init.py | Adds AAZ “latest” API version package marker. |
| src/managedcleanroom/azext_managedcleanroom/aaz/latest/managedcleanroom/init.py | Adds top-level AAZ managedcleanroom command group import wiring. |
| src/managedcleanroom/azext_managedcleanroom/aaz/latest/managedcleanroom/__cmd_group.py | Defines the top-level managedcleanroom command group. |
| src/managedcleanroom/azext_managedcleanroom/aaz/latest/managedcleanroom/private_endpoint_util.py | Adds utility to switch provider namespace based on environment variable. |
| src/managedcleanroom/azext_managedcleanroom/aaz/latest/managedcleanroom/consortium/init.py | Imports consortium command implementations for the AAZ command group. |
| src/managedcleanroom/azext_managedcleanroom/aaz/latest/managedcleanroom/consortium/__cmd_group.py | Defines the managedcleanroom consortium command group. |
| src/managedcleanroom/azext_managedcleanroom/aaz/latest/managedcleanroom/consortium/_create.py | Adds az managedcleanroom consortium create command implementation. |
| src/managedcleanroom/azext_managedcleanroom/aaz/latest/managedcleanroom/consortium/_delete.py | Adds az managedcleanroom consortium delete command implementation. |
| src/managedcleanroom/azext_managedcleanroom/aaz/latest/managedcleanroom/consortium/_list.py | Adds az managedcleanroom consortium list command implementation. |
| src/managedcleanroom/azext_managedcleanroom/aaz/latest/managedcleanroom/consortium/_pause.py | Adds az managedcleanroom consortium pause command implementation. |
| src/managedcleanroom/azext_managedcleanroom/aaz/latest/managedcleanroom/consortium/_recover.py | Adds az managedcleanroom consortium recover command implementation. |
| src/managedcleanroom/azext_managedcleanroom/aaz/latest/managedcleanroom/consortium/_resume.py | Adds az managedcleanroom consortium resume command implementation. |
| src/managedcleanroom/azext_managedcleanroom/aaz/latest/managedcleanroom/consortium/_show.py | Adds az managedcleanroom consortium show command implementation. |
| src/managedcleanroom/azext_managedcleanroom/aaz/latest/managedcleanroom/consortium/_wait.py | Adds az managedcleanroom consortium wait command implementation. |
| src/managedcleanroom/azext_managedcleanroom/aaz/latest/managedcleanroom/consortium_view/init.py | Imports consortium-view command implementations for the AAZ command group. |
| src/managedcleanroom/azext_managedcleanroom/aaz/latest/managedcleanroom/consortium_view/__cmd_group.py | Defines the managedcleanroom consortium-view command group. |
| src/managedcleanroom/azext_managedcleanroom/aaz/latest/managedcleanroom/consortium_view/_create.py | Adds az managedcleanroom consortium-view create command implementation. |
| src/managedcleanroom/azext_managedcleanroom/aaz/latest/managedcleanroom/consortium_view/_delete.py | Adds az managedcleanroom consortium-view delete command implementation. |
| src/managedcleanroom/azext_managedcleanroom/aaz/latest/managedcleanroom/consortium_view/_list.py | Adds az managedcleanroom consortium-view list command implementation. |
| src/managedcleanroom/azext_managedcleanroom/aaz/latest/managedcleanroom/consortium_view/_show.py | Adds az managedcleanroom consortium-view show command implementation. |
| src/managedcleanroom/azext_managedcleanroom/aaz/latest/managedcleanroom/consortium_view/_update.py | Adds az managedcleanroom consortium-view update command implementation. |
| src/managedcleanroom/azext_managedcleanroom/aaz/latest/managedcleanroom/consortium_view/_wait.py | Adds az managedcleanroom consortium-view wait command implementation. |
| src/managedcleanroom/azext_managedcleanroom/aaz/latest/managedcleanroom/consortium_view/contract/init.py | Imports contract subcommands under consortium-view for AAZ registration. |
| src/managedcleanroom/azext_managedcleanroom/aaz/latest/managedcleanroom/consortium_view/contract/__cmd_group.py | Defines the managedcleanroom consortium-view contract command group. |
| src/managedcleanroom/azext_managedcleanroom/aaz/latest/managedcleanroom/consortium_view/contract/_list.py | Adds az managedcleanroom consortium-view contract list command implementation. |
| src/managedcleanroom/azext_managedcleanroom/aaz/latest/managedcleanroom/consortium_view/contract/_propose_template.py | Adds az managedcleanroom consortium-view contract propose-template command implementation. |
| src/managedcleanroom/azext_managedcleanroom/aaz/latest/managedcleanroom/consortium_view/contract/_show.py | Adds az managedcleanroom consortium-view contract show command implementation. |
| src/managedcleanroom/azext_managedcleanroom/aaz/latest/managedcleanroom/collaboration/init.py | Imports collaboration command implementations for the AAZ command group. |
| src/managedcleanroom/azext_managedcleanroom/aaz/latest/managedcleanroom/collaboration/__cmd_group.py | Defines the managedcleanroom collaboration command group. |
| src/managedcleanroom/azext_managedcleanroom/aaz/latest/managedcleanroom/collaboration/_add_collaborator.py | Adds az managedcleanroom collaboration add-collaborator command implementation. |
| src/managedcleanroom/azext_managedcleanroom/aaz/latest/managedcleanroom/collaboration/_create.py | Adds az managedcleanroom collaboration create command implementation. |
| src/managedcleanroom/azext_managedcleanroom/aaz/latest/managedcleanroom/collaboration/_delete.py | Adds az managedcleanroom collaboration delete command implementation. |
| src/managedcleanroom/azext_managedcleanroom/aaz/latest/managedcleanroom/collaboration/_enable_workload.py | Adds az managedcleanroom collaboration enable-workload command implementation. |
| src/managedcleanroom/azext_managedcleanroom/aaz/latest/managedcleanroom/collaboration/_pause.py | Adds az managedcleanroom collaboration pause command implementation. |
| src/managedcleanroom/azext_managedcleanroom/aaz/latest/managedcleanroom/collaboration/_recover.py | Adds az managedcleanroom collaboration recover command implementation. |
| src/managedcleanroom/azext_managedcleanroom/aaz/latest/managedcleanroom/collaboration/_resume.py | Adds az managedcleanroom collaboration resume command implementation. |
| src/managedcleanroom/azext_managedcleanroom/aaz/latest/managedcleanroom/collaboration/_show.py | Adds az managedcleanroom collaboration show command implementation. |
| src/managedcleanroom/azext_managedcleanroom/aaz/latest/managedcleanroom/collaboration/_wait.py | Adds az managedcleanroom collaboration wait command implementation. |
| src/managedcleanroom/azext_managedcleanroom/tests/init.py | Adds test package marker. |
| src/managedcleanroom/azext_managedcleanroom/tests/latest/init.py | Adds latest-tests package marker. |
| src/managedcleanroom/azext_managedcleanroom/tests/latest/test_managedcleanroom.py | Adds placeholder scenario test file for the new extension. |
| src/managedcleanroom/azext_managedcleanroom/tests/latest/test_private_endpoint_util.py | Adds unit tests for namespace-selection behavior. |
src/managedcleanroom/azext_managedcleanroom/tests/latest/test_private_endpoint_util.py
Show resolved
Hide resolved
|
@kkarmakarMS could you plz provide the link of pr in Azure/aaz? thx. |
|
@necusjz Please find the PR for the aaz repo: |
|
[Release] Update index.json for extension [ managedcleanroom-1.0.0b1 ] : https://dev.azure.com/msazure/One/_build/results?buildId=151500536&view=results |
* Adding commands for Microsoft.CleanRoom * Use private namespace dynamically * Update command should use PATCH HTTP call * Fix linting * Add readme contents * Reduce parameter size * Fix long parameters * Add service to service_name.json * Add service to service_name.json * Add simple test
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
We are adding a new extension "az managedcleanroom" for Microsoft.CleanRoom resource provider.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.Azure/aaz repo PR:
Azure/aaz#934