{Pylint} Fix super-with-arguments (#30367)

Author: atombrella

pylintrc

@@ -30,7 +30,6 @@ disable=
     no-value-for-parameter,
     raise-missing-from,
     subprocess-run-check,
-    super-with-arguments,
     too-many-arguments,
     too-many-positional-arguments,
     too-many-function-args,

scripts/dump_command_table.py

@@ -16,7 +16,7 @@ class Exporter(json.JSONEncoder):
 
     def default(self, o):#pylint: disable=method-hidden
         try:
-            return super(Exporter, self).default(o)
+            return super().default(o)
         except TypeError:
             return str(o)
 

scripts/dump_help.py

@@ -16,7 +16,7 @@ class Exporter(json.JSONEncoder):
 
     def default(self, o):#pylint: disable=method-hidden
         try:
-            return super(Exporter, self).default(o)
+            return super().default(o)
         except TypeError:
             return str(o)
 

scripts/generate_command_inventory.py

@@ -14,7 +14,7 @@ class Exporter(json.JSONEncoder):
 
     def default(self, o):#pylint: disable=method-hidden
         try:
-            return super(Exporter, self).default(o)
+            return super().default(o)
         except TypeError:
             return str(o)
 

src/azure-cli-core/azure/cli/core/__init__.py

@@ -56,7 +56,7 @@ def _configure_knack():
 class AzCli(CLI):
 
     def __init__(self, **kwargs):
-        super(AzCli, self).__init__(**kwargs)
+        super().__init__(**kwargs)
 
         from azure.cli.core.breaking_change import register_upcoming_breaking_change_info
         from azure.cli.core.commands import register_cache_arguments
@@ -200,7 +200,7 @@ class MainCommandsLoader(CLICommandsLoader):
     item_ext_format_string = item_format_string + "  %s"
 
     def __init__(self, cli_ctx=None):
-        super(MainCommandsLoader, self).__init__(cli_ctx)
+        super().__init__(cli_ctx)
         self.cmd_to_loader_map = {}
         self.loaders = []
 
@@ -677,9 +677,9 @@ def __init__(self, cli_ctx=None, command_group_cls=None, argument_context_cls=No
                  suppress_extension=None, **kwargs):
         from azure.cli.core.commands import AzCliCommand, AzCommandGroup, AzArgumentContext
 
-        super(AzCommandsLoader, self).__init__(cli_ctx=cli_ctx,
-                                               command_cls=AzCliCommand,
-                                               excluded_command_handler_args=EXCLUDED_PARAMS)
+        super().__init__(cli_ctx=cli_ctx,
+                         command_cls=AzCliCommand,
+                         excluded_command_handler_args=EXCLUDED_PARAMS)
         self.suppress_extension = suppress_extension
         self.module_kwargs = kwargs
         self.command_name = None

src/azure-cli-core/azure/cli/core/_help.py

@@ -50,7 +50,7 @@
 # Most of these methods override print methods in CLIHelp
 class CLIPrintMixin(CLIHelp):
     def _print_header(self, cli_name, help_file):
-        super(CLIPrintMixin, self)._print_header(cli_name, help_file)
+        super()._print_header(cli_name, help_file)
 
         links = help_file.links
         if links:
@@ -61,7 +61,7 @@ def _print_header(self, cli_name, help_file):
 
     def _print_detailed_help(self, cli_name, help_file):
         CLIPrintMixin._print_extensions_msg(help_file)
-        super(CLIPrintMixin, self)._print_detailed_help(cli_name, help_file)
+        super()._print_detailed_help(cli_name, help_file)
         self._print_az_find_message(help_file.command)
 
     @staticmethod
@@ -131,12 +131,11 @@ def _print_extensions_msg(help_file):
 class AzCliHelp(CLIPrintMixin, CLIHelp):
 
     def __init__(self, cli_ctx):
-        super(AzCliHelp, self).__init__(cli_ctx,
-                                        privacy_statement=PRIVACY_STATEMENT,
-                                        welcome_message=WELCOME_MESSAGE,
-                                        command_help_cls=CliCommandHelpFile,
-                                        group_help_cls=CliGroupHelpFile,
-                                        help_cls=CliHelpFile)
+        super().__init__(cli_ctx, privacy_statement=PRIVACY_STATEMENT,
+                         welcome_message=WELCOME_MESSAGE,
+                         command_help_cls=CliCommandHelpFile,
+                         group_help_cls=CliGroupHelpFile,
+                         help_cls=CliHelpFile)
         from knack.help import HelpObject
 
         # TODO: This workaround is used to avoid a bizarre bug in Python 2.7. It
@@ -247,7 +246,7 @@ class CliHelpFile(KnackHelpFile):
 
     def __init__(self, help_ctx, delimiters):
         # Each help file (for a command or group) has a version denoting the source of its data.
-        super(CliHelpFile, self).__init__(help_ctx, delimiters)
+        super().__init__(help_ctx, delimiters)
         self.links = []
 
         from knack.deprecation import resolve_deprecate_info, ImplicitDeprecated, Deprecated
@@ -376,7 +375,7 @@ def load(self, options):
 class CliCommandHelpFile(KnackCommandHelpFile, CliHelpFile):
 
     def __init__(self, help_ctx, delimiters, parser):
-        super(CliCommandHelpFile, self).__init__(help_ctx, delimiters, parser)
+        super().__init__(help_ctx, delimiters, parser)
         self.type = 'command'
         self.command_source = getattr(parser, 'command_source', None)
 
@@ -409,7 +408,7 @@ def __init__(self, help_ctx, delimiters, parser):
             param.__class__ = HelpParameter
 
     def _load_from_data(self, data):
-        super(CliCommandHelpFile, self)._load_from_data(data)
+        super()._load_from_data(data)
 
         if isinstance(data, str) or not self.parameters or not data.get('parameters'):
             return
@@ -433,7 +432,7 @@ class ArgumentGroupRegistry(KnackArgumentGroupRegistry):  # pylint: disable=too-
 
     def __init__(self, group_list):
 
-        super(ArgumentGroupRegistry, self).__init__(group_list)
+        super().__init__(group_list)
         self.priorities = {
             None: 0,
             'Resource Id Arguments': 1,
@@ -454,7 +453,7 @@ def __init__(self, **_data):
         # Old attributes
         _data['name'] = _data.get('name', '')
         _data['text'] = _data.get('text', '')
-        super(HelpExample, self).__init__(_data)
+        super().__init__(_data)
 
         self.name = _data.get('summary', '') if _data.get('summary', '') else self.name
         self.text = _data.get('command', '') if _data.get('command', '') else self.text
@@ -483,11 +482,8 @@ def command(self, value):
 
 class HelpParameter(KnackHelpParameter):  # pylint: disable=too-many-instance-attributes
 
-    def __init__(self, **kwargs):
-        super(HelpParameter, self).__init__(**kwargs)
-
     def update_from_data(self, data):
-        super(HelpParameter, self).update_from_data(data)
+        super().update_from_data(data)
         # original help.py value_sources are strings, update command strings to value-source dict
         if self.value_sources:
             self.value_sources = [str_or_dict if isinstance(str_or_dict, dict) else {"link": {"command": str_or_dict}}

src/azure-cli-core/azure/cli/core/_session.py

@@ -21,7 +21,7 @@ class Session(MutableMapping):
     """
 
     def __init__(self, encoding=None):
-        super(Session, self).__init__()
+        super().__init__()
         self.filename = None
         self.data = {}
         self._encoding = encoding if encoding else 'utf-8-sig'

src/azure-cli-core/azure/cli/core/aaz/_arg.py

@@ -358,9 +358,6 @@ def _type_in_help(self):
 
 class AAZCompoundTypeArg(AAZBaseArg):
 
-    def __init__(self, **kwargs):
-        super().__init__(**kwargs)
-
     @abc.abstractmethod
     def _build_cmd_action(self):
         raise NotImplementedError()

src/azure-cli-core/azure/cli/core/aaz/_field_type.py

@@ -24,9 +24,6 @@ class AAZSimpleType(AAZBaseType):
 
     _ValueCls = AAZSimpleValue
 
-    def __init__(self, *args, **kwargs):
-        super().__init__(*args, **kwargs)
-
     def process_data(self, data, **kwargs):
         if data == None:  # noqa: E711, pylint: disable=singleton-comparison
             # data can be None or AAZSimpleValue == None
@@ -276,9 +273,6 @@ class AAZBaseDictType(AAZBaseType):
 
     _PatchDataCls = dict
 
-    def __init__(self, *args, **kwargs):
-        super().__init__(*args, **kwargs)
-
     @abc.abstractmethod
     def __getitem__(self, key):
         raise NotImplementedError()

src/azure-cli-core/azure/cli/core/azlogging.py

@@ -42,15 +42,15 @@ class AzCliLogging(CLILogging):
     COMMAND_METADATA_LOGGER = 'az_command_data_logger'
 
     def __init__(self, name, cli_ctx=None):
-        super(AzCliLogging, self).__init__(name, cli_ctx)
+        super().__init__(name, cli_ctx)
         self.command_log_dir = os.path.join(cli_ctx.config.config_dir, 'commands')
         self.command_logger_handler = None
         self.command_metadata_logger = None
         self.cli_ctx.register_event(EVENT_INVOKER_PRE_CMD_TBL_TRUNCATE, AzCliLogging.init_command_file_logging)
         self.cli_ctx.register_event(EVENT_CLI_POST_EXECUTE, AzCliLogging.deinit_cmd_metadata_logging)
 
     def configure(self, args):
-        super(AzCliLogging, self).configure(args)
+        super().configure(args)
         from knack.log import CliLogLevel
         if self.log_level == CliLogLevel.DEBUG:
             # As azure.core.pipeline.policies.http_logging_policy is a redacted version of