[AppService] az functionapp create: Use app insights connection string instead of instrumentation key#27803
Merged
zhoxing-ms merged 6 commits intoAzure:devfrom Jan 10, 2024
Merged
Conversation
kamperiadis
requested review from
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
AppService |
Contributor
|
@kamperiadis May I ask will the behavioral changes here cause breaking changes to the automation scripts of customers? |
Contributor
|
@kaibocai Could you please help review the Function App related PR? |
zhoxing-ms
modified the milestones:
November 2023 (2023-12-05),
December 2023 (2024-01-02)
Contributor
Author
|
@zhoxing-ms This is not a breaking change as using either app setting would work. These changes are made for this effort to migrate from the instrumentation key to the connection string. |
Contributor
Okay, so this is just an internal logic modification and won't have any impact on the customers' script, right? |
Contributor
|
Could you please resolve these CI issues? |
zhoxing-ms
modified the milestones:
December 2023 (2024-01-09),
January 2024 (2024-02-06)
Contributor
Author
That is correct. |
zhoxing-ms
approved these changes
Jan 10, 2024
MaxHorstmann
pushed a commit
to MaxHorstmann/azure-cli
that referenced
this pull request
Jan 19, 2024
…ing instead of instrumentation key (Azure#27803)
bebound
reviewed
Dec 6, 2024
| class FunctionAppWithAppInsightsConnString(ScenarioTest): | ||
| def __init__(self, method_name, config_file=None, recording_name=None, recording_processors=None, replay_processors=None, recording_patches=None, replay_patches=None, random_config_dir=False): | ||
| super().__init__(method_name, config_file, recording_name, recording_processors, replay_processors, recording_patches, replay_patches, random_config_dir) | ||
| self.cmd('extension add -n application-insights') |
Contributor
There was a problem hiding this comment.
extension add -n should not be here. It causes CI failure:
==================================== ERRORS ====================================
__________ ERROR collecting tests/latest/test_functionapp_commands.py __________
/usr/lib64/az/lib/python3.9/site-packages/azure/cli/command_modules/appservice/tests/latest/test_functionapp_commands.py:990: in __init__
self.cmd('extension add -n application-insights')
/usr/lib64/az/lib/python3.9/site-packages/azure/cli/testsdk/base.py:176: in cmd
return execute(self.cli_ctx, command, expect_failure=expect_failure).assert_with_checks(checks)
/usr/lib64/az/lib/python3.9/site-packages/azure/cli/testsdk/base.py:260: in __init__
raise AssertionError('The command failed. Exit code: {}'.format(self.exit_code))
E AssertionError: The command failed. Exit code: 1
__________ ERROR collecting tests/latest/test_functionapp_commands.py __________
/usr/lib64/az/lib/python3.9/site-packages/azure/cli/command_modules/appservice/tests/latest/test_functionapp_commands.py:1579: in __init__
self.cmd('extension add -n application-insights')
/usr/lib64/az/lib/python3.9/site-packages/azure/cli/testsdk/base.py:176: in cmd
return execute(self.cli_ctx, command, expect_failure=expect_failure).assert_with_checks(checks)
/usr/lib64/az/lib/python3.9/site-packages/azure/cli/testsdk/base.py:260: in __init__
raise AssertionError('The command failed. Exit code: {}'.format(self.exit_code))
E AssertionError: The command failed. Exit code: 1
__________ ERROR collecting tests/latest/test_functionapp_commands.py __________
/usr/lib64/az/lib/python3.9/site-packages/azure/cli/command_modules/appservice/tests/latest/test_functionapp_commands.py:1707: in __init__
self.cmd('extension add -n application-insights')
/usr/lib64/az/lib/python3.9/site-packages/azure/cli/testsdk/base.py:176: in cmd
return execute(self.cli_ctx, command, expect_failure=expect_failure).assert_with_checks(checks)
/usr/lib64/az/lib/python3.9/site-packages/azure/cli/testsdk/base.py:260: in __init__
raise AssertionError('The command failed. Exit code: {}'.format(self.exit_code))
E AssertionError: The command failed. Exit code: 1
---------- generated xml file: /azure_cli_test_result/appservice.xml -----------
=========================== short test summary info ============================
ERROR tests/latest/test_functionapp_commands.py::FunctionAppManagedEnvironment
ERROR tests/latest/test_functionapp_commands.py::FunctionAppWithAppInsightsConnString
ERROR tests/latest/test_functionapp_commands.py::FunctionappAppInsightsWorkspace
Contributor
There was a problem hiding this comment.
@kamperiadis Could you please take a look at this issue?
Contributor
Author
There was a problem hiding this comment.
@zhoxing-ms I've created this PR to solve this issue: #30636
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az functionapp createDescription
Resolves #27607
Testing Guide
Create function app and check that app setting added is
APPLICATIONINSIGHTS_CONNECTION_STRINGinstead ofAPPINSIGHTS_INSTRUMENTATION_KEYThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.